Fix memory leak in clients/horizonclient/client.go:166 - stream (#5747)

vxxvvxxv · Vladimir Sokolovskiy · Shaptic · web-flow · commit be943c360056 · 2025-07-17T23:53:57.000-07:00
* fix: memory leak in stream operations

* chore: change CHANGELOG.md

---------

Co-authored-by: Vladimir Sokolovskiy &lt;vladimir.sokolovskiy@armenotech.com&gt;
Co-authored-by: George &lt;Shaptic@users.noreply.github.com&gt;
diff --git a/clients/horizonclient/CHANGELOG.md b/clients/horizonclient/CHANGELOG.md
@@ -8,6 +8,7 @@ file.  This project adheres to [Semantic Versioning](http://semver.org/).
 ## [v11.0.0](https://github.com/stellar/go/releases/tag/horizonclient-v11.0.0) - 2023-03-29
 
 * Type of `AccountSequence` field in `protocols/horizon.Account` was changed to `int64`.
+* Fixed memory leak in `stream` function in `client.go` due to incorrect `resp.Body.Close` handling.
 
 ## [v10.0.0](https://github.com/stellar/go/releases/tag/horizonclient-v10.0.0) - 2022-04-18
 
diff --git a/clients/horizonclient/client.go b/clients/horizonclient/client.go
@@ -158,12 +158,12 @@ func (c *Client) stream(
 		if err != nil {
 			return errors.Wrap(err, "error sending HTTP request")
 		}
+		defer resp.Body.Close()
 
 		// Expected statusCode are 200-299
 		if !(resp.StatusCode >= 200 && resp.StatusCode < 300) {
 			return fmt.Errorf("got bad HTTP status code %d", resp.StatusCode)
 		}
-		defer resp.Body.Close()
 
 		reader := bufio.NewReader(resp.Body)
 

Original file line number	Diff line number	Diff line change
`@@ -158,12 +158,12 @@ func (c *Client) stream(`
`158`	`158`	`if err != nil {`
`159`	`159`	`return errors.Wrap(err, "error sending HTTP request")`
`160`	`160`	`}`
	`161`	`+ defer resp.Body.Close()`
`161`	`162`
`162`	`163`	`// Expected statusCode are 200-299`
`163`	`164`	`if !(resp.StatusCode >= 200 && resp.StatusCode < 300) {`
`164`	`165`	`return fmt.Errorf("got bad HTTP status code %d", resp.StatusCode)`
`165`	`166`	`}`
`166`		`- defer resp.Body.Close()`
`167`	`167`
`168`	`168`	`reader := bufio.NewReader(resp.Body)`
`169`	`169`