more fixes

Author: urvisavla

services/horizon/internal/integration/generate_ledgers_test.go

@@ -37,6 +37,10 @@ type sorobanTransaction struct {
 }
 
 func TestGenerateLedgers(t *testing.T) {
+	// TODO: Add support for LedgerCloseMetaV2 to run this test for Protocol 23 and above
+	if integration.GetCoreMaxSupportedProtocol() > 22 {
+		t.Skip("This test run does not support greater than Protocol 22")
+	}
 
 	var transactionsPerLedger, ledgers, transfersPerTx int
 	var output bool

services/horizon/internal/integration/invokehostfunction_test.go

@@ -184,7 +184,6 @@ func TestContractInvokeHostFunctionCreateContractByAddress(t *testing.T) {
 }
 
 func TestContractInvokeHostFunctionCreateConstructorContract(t *testing.T) {
-	return
 	itest := integration.NewTest(t, integration.Config{
 		EnableStellarRPC: true,
 		QuickExpiration:  true,
@@ -267,9 +266,15 @@ func TestContractInvokeHostFunctionCreateConstructorContract(t *testing.T) {
 	assert.Len(t, invokeHostFunctionOpJson.AssetBalanceChanges, 1)
 	assetBalanceChange := invokeHostFunctionOpJson.AssetBalanceChanges[0]
 	assert.Equal(itest.CurrentTest(), assetBalanceChange.Amount, "10.0000000")
-	assert.Equal(itest.CurrentTest(), assetBalanceChange.From, issuer)
 	assert.Equal(itest.CurrentTest(), assetBalanceChange.To, strkey.MustEncode(strkey.VersionByteContract, contractID[:]))
-	assert.Equal(itest.CurrentTest(), assetBalanceChange.Type, "transfer")
+	if integration.GetCoreMaxSupportedProtocol() < 23 {
+		assert.Equal(itest.CurrentTest(), assetBalanceChange.From, issuer)
+		assert.Equal(itest.CurrentTest(), assetBalanceChange.Type, "transfer")
+	} else {
+		// see https://github.com/stellar/stellar-protocol/blob/master/core/cap-0067.md#protocol-upgrade-transition
+		assert.Equal(itest.CurrentTest(), assetBalanceChange.From, "")
+		assert.Equal(itest.CurrentTest(), assetBalanceChange.Type, "mint")
+	}
 	assert.Equal(itest.CurrentTest(), assetBalanceChange.Asset.Code, strings.TrimRight(asset.GetCode(), "\x00"))
 	assert.Equal(itest.CurrentTest(), assetBalanceChange.Asset.Issuer, asset.GetIssuer())
 }

services/horizon/internal/integration/sac_test.go

@@ -103,6 +103,7 @@ func TestContractMintToAccount(t *testing.T) {
 			effects.EffectAccountCredited,
 			effects.EffectAccountDebited)
 	} else {
+		// see https://github.com/stellar/stellar-protocol/blob/master/core/cap-0067.md#remove-the-admin-from-the-sac-mint-and-clawback-events
 		assert.Len(t, fx, 1)
 		assertContainsEffect(t, fx,
 			effects.EffectAccountCredited)