Commit 500fa07
authored
Add safety notes about docs fields in soroban-spec-rust (#1650)
### What
Add and update comments in soroban-spec-rust explaining why the "docs"
fields from spec entries are intentionally not output as rustdocs in
generated Rust code.
### Why
Rustdocs can contain Rust code that gets executed. Generated code may
come from untrusted WASMs with untrusted spec docs, creating a code
execution risk.
We already have a comment about this in one of the files, but I wanted
to put this important note at the top of all the files in this crate so
it's present to anybody who's reading any of them.1 parent 086daf6 commit 500fa07
3 files changed
+13
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
8 | 13 | | |
9 | 14 | | |
10 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
0 commit comments