Merge branch 'main' into str-to-ident-into-ident

Author: leighmcculloch

.github/workflows/test-with-soroban-examples.yml

@@ -42,6 +42,16 @@ jobs:
       matrix:
         working-directory: ${{ fromJSON(needs.collect-examples.outputs.dirs) }}
         experimental_spec_shaking_v2: [true, false]
+        # Exclude examples that depend on crates.io packages that transitively
+        # depend on soroban-sdk (e.g. soroban-poseidon). Cargo does not provide
+        # a way to override the version of soroban-sdk required as a transitive
+        # dependency of another dependency where the version to override is a
+        # different major version or does not match the semver compatibility
+        # defined by the importer, causing two copies of soroban-sdk to be
+        # compiled and duplicate lang item (panic_impl) errors.
+        # https://github.com/stellar/rs-soroban-sdk/issues/1723
+        exclude:
+        - working-directory: privacy-pools
     defaults:
       run:
         working-directory: soroban-examples/${{ matrix.working-directory }}

soroban-sdk/src/lib.rs

@@ -412,6 +412,22 @@ pub use soroban_sdk_macros::contract;
 /// Functions that are publicly accessible in the implementation are invocable
 /// by other contracts, or directly by transactions, when deployed.
 ///
+/// ### Notes
+///
+/// Each public function's export name is derived from the function name alone,
+/// without any type prefix or namespace. This means:
+///
+/// - **Function names must be unique across all `#[contractimpl]` blocks in a
+///   crate.** If two impl blocks define a function with the same name, their
+///   Wasm exports will collide, producing build or linker errors.
+///
+/// - **Importing a crate that contains `#[contractimpl]` blocks will pull its
+///   exported functions into the importing crate's Wasm binary.** This is a
+///   limitation of Rust — any `#[export_name = "..."]` function in a dependency
+///   is included in the final binary. This can cause unexpected exports or name
+///   collisions that are hard to diagnose. For this reason it is usually
+///   inadvisable to import dependencies that use `#[contractimpl]`.
+///
 /// ### Examples
 ///
 /// Define a contract with one function, `hello`, and call it from within a test