BUG: Convert disk size from MB to GB for Aquilon (#49)

* BUG: Convert disk from MB to GB for Aquilon

An update in NetBox has changed the disk size to be stored in MB
instead of GB. This results in the code setting the disk size in Aquilon
to be too large e.g. if a disk is 1024 MB in NetBox, the disk is set for
the device as 1024 GB in Aquilon. Added a line to convert the disk size
to GB.

Netbox defines GB as SI/1000 and GiB as EIC/1024.

Author: meoflynn

aquilon/netbox2aquilon.py

@@ -140,12 +140,15 @@ def _netbox_copy_vm_disks(self, virtual_machine):
         if virtual_disks:
             boot = True
             for disk in virtual_disks:
+                # Netbox stores virtual disk size in MB, Aquilon needs it in GB
+                # For netbox 1000 MB = 1GB
+                virtual_disk_gb = round(disk.size / 1000) # to nearest GB
                 cmd = [
                     'add_disk',
                     '--machine', f'{virtual_machine.aq_machine_name}',
                     '--disk', f'{disk.name}',
                     '--controller', 'sata',
-                    '--size', f'{disk.size}',
+                    '--size', f'{virtual_disk_gb}',
                 ]
                 if boot:
                     cmd.append('--boot')
@@ -154,12 +157,14 @@ def _netbox_copy_vm_disks(self, virtual_machine):
                     cmd += ['--comments', f'"{disk.description}"']
                 cmds.append(cmd)
         else:
+            # Netbox stores disk size in MB, Aquilon needs it in GB
+            disk_gb = round(virtual_machine.disk / 1000) # to nearest GB
             cmds.append([
                 'add_disk',
                 '--machine', f'{virtual_machine.aq_machine_name}',
                 '--disk', 'sda',
                 '--controller', 'sata',
-                '--size', f'{virtual_machine.disk}',
+                '--size', f'{disk_gb}',
                 '--boot',
             ])
 

aquilon/testdata/disks_virtual.json

@@ -11,7 +11,7 @@
     },
     "name": "sda",
     "description": "",
-    "size": 40,
+    "size": 40000,
     "tags": [],
     "custom_fields": {},
     "created": "2025-06-02T13:43:40.552134Z",
@@ -29,7 +29,7 @@
     },
     "name": "sdb",
     "description": "",
-    "size": 100,
+    "size": 100000,
     "tags": [],
     "custom_fields": {},
     "created": "2025-06-02T13:43:49.494852Z",
@@ -47,7 +47,7 @@
     },
     "name": "sdc",
     "description": "/opt",
-    "size": 100,
+    "size": 100000,
     "tags": [],
     "custom_fields": {},
     "created": "2025-06-02T13:44:01.016349Z",