Replies: 1 comment 1 reply
-
|
If you think this is fine, I'm very glad to PR |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, last time I made a PR about making comments a parameter in api
process_js_with_custom_pass(), and I was wrong because my ignorance, you correct me that comments are stored in inner data, and can be cloned easily.But now I still want to make
commentsoutside of that API. Because it also need a Option as parameter, so If I'm right then I think I can give it an already parsed AST, but when I parse I also need acommentsto parse, so thecommentsusing for parsing and thecommentsfor transforming should be the same.I'm not sure though, I tried give a comments for parsing and a new one for
process_js_with_custom_pass, and find out no comments in the result.If I'm wrong again, sorry for bothering
Beta Was this translation helpful? Give feedback.
All reactions