Why swc test_inline always passed?

[chenwll]

I want to in try... catch... catch error message, and add console.log(error)
this is my code

use swc_core::common::DUMMY_SP;
use swc_core::ecma::{
    ast::Program,
    transforms::testing::test_inline,
    transforms::testing::test,
    visit::{as_folder, FoldWith, VisitMut},
};
use swc_core::ecma::ast::{CallExpr, CatchClause, Expr, ExprOrSpread, ExprStmt, Ident, MemberExpr, MemberProp, Pat, Stmt};
use swc_core::ecma::visit::{ VisitMutWith};
use swc_core::plugin::{plugin_transform, proxies::TransformPluginProgramMetadata};

pub struct CatchClauseVisitor;

impl VisitMut for CatchClauseVisitor {
    fn visit_mut_catch_clause(&mut self, catch_clause: &mut CatchClause) {
        println!("swc plugin");
        // 提取标识符
        let error_ident = match &catch_clause.param {
            Some(pat) => match &*pat {
                Pat::Ident(ident) => ident.id.clone(),
                _ => return, // we only handle simple cases where catch clause param is an identifier
            },
            None => return,
        };

        let console_ident = Ident::new("console".into(), DUMMY_SP);
        let log_ident = Ident::new("log".into(), DUMMY_SP);

        // console.log(error)
        // callee: MemberExpression
        let console_log_expr = Expr::Member(MemberExpr {
            obj: Box::new(Expr::Ident(console_ident)),
            prop: *Box::new(MemberProp::Ident(log_ident)),
            span: DUMMY_SP,
        });

        // expression: CallExpression
        let log_error_call_expr = Expr::Call(CallExpr {
            callee: Box::new(console_log_expr).into(),
            args: vec![ExprOrSpread {
                expr: Box::new(Expr::Ident(error_ident)),
                spread: None,
            }],
            type_args: None,
            span: DUMMY_SP,
        });

        let log_error_stmt = Stmt::Expr(ExprStmt {
            span: DUMMY_SP,
            expr: Box::new(log_error_call_expr),
        });

        catch_clause.body.stmts.insert(0, log_error_stmt);

        println!("{:?}", catch_clause.body.stmts);

        catch_clause.visit_mut_children_with(self);
    }
}

/// 插件入口
#[plugin_transform]
pub fn process_transform(program: Program, _metadata: TransformPluginProgramMetadata) -> Program {
    program.fold_with(&mut as_folder(CatchClauseVisitor))
}

// An example to test plugin transform.
// Recommended strategy to test plugin's transform is verify
// the Visitor's behavior, instead of trying to run `process_transform` with mocks
// unless explicitly required to do so.
test_inline!(
    Default::default(),
    |_| as_folder(CatchClauseVisitor),
    catch_test,
    // Input codes
    r#"
    try{
        let a = 1;
    }catch(error){
    }
    "#,
    // Output codes after transformed with plugin
    r#"
    console.log('aaa');
    "#
);


test_inline!(
    Default::default(),
    |_| as_folder(CatchClauseVisitor),
    catch_test2,
    // Input codes
    r#"try{
        let a = 1;
    }catch(error){
    }"#,
    // Output codes after transformed with plugin
    r#"try{
        let a = 1;
    }catch(error){
        console.log(error);
    }"#
);

but when i run cargo test，two examples has passed, but It's obviously wrong, i want know why?

 Compiling my-swc-plugin v0.1.0 (/Users/enliang/AProject/my-swc-plugin)
    Finished test [unoptimized + debuginfo] target(s) in 3.63s
     Running unittests src/lib.rs (target/debug/deps/my_swc_plugin-bfea6d45db4e5c3f)

running 2 tests
test catch_test2 ... ok
test catch_test ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

[kdy1]

Seems like the impl of test_inline has a bug

[chenwll]

Thanks! Wait for your good news

[kdy1]

It was a bug of old package. Please update swc_core or swc_ecma_transforms_testing.