feat: reduce build binary size (#4228)

Author: sxyazi

.cargo/release.toml

@@ -2,4 +2,18 @@
 trim-paths = "all"
 
 [target.'cfg(all())']
-rustflags = [ "-Cpasses=mergefunc" ]
+rustflags = [
+	"-Cpasses=mergefunc",
+	"-Zshare-generics=true",
+]
+
+# LLD lacks the SPARC GOTDATA_OP relocations emitted by GCC.
+[target.'cfg(all(target_os = "linux", not(target_arch = "sparc64")))']
+rustflags = [
+	"-Clink-arg=-fuse-ld=lld",
+	"-Clink-arg=-Wl,--icf=safe",
+	"-Clink-arg=-Wl,-z,pack-relative-relocs",
+]
+
+[target.'cfg(target_os = "macos")']
+rustflags = [ "-Clink-arg=-Wl,-O1" ]

.github/workflows/draft.yml

@@ -19,9 +19,8 @@ jobs:
         include:
           - os: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-          - os: ubuntu-latest
+          - os: ubuntu-24.04-arm
             target: aarch64-unknown-linux-gnu
-            gcc: gcc-aarch64-linux-gnu
           - os: ubuntu-latest
             target: i686-unknown-linux-gnu
             gcc: gcc-i686-linux-gnu
@@ -37,7 +36,6 @@ jobs:
             target: aarch64-apple-darwin
     runs-on: ${{ matrix.os }}
     env:
-      CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
       CARGO_TARGET_I686_UNKNOWN_LINUX_GNU_LINKER: i686-linux-gnu-gcc
       CARGO_TARGET_RISCV64GC_UNKNOWN_LINUX_GNU_LINKER: riscv64-linux-gnu-gcc
       CARGO_TARGET_SPARC64_UNKNOWN_LINUX_GNU_LINKER: sparc64-linux-gnu-gcc

nix/yazi-unwrapped.nix

@@ -4,6 +4,7 @@
   rev ? "unknown",
   date ? "19700101",
   lib,
+  stdenv,
 
   installShellFiles,
   fetchFromGitHub,
@@ -15,6 +16,7 @@ let
   src = lib.fileset.toSource {
     root = ../.;
     fileset = lib.fileset.unions [
+      ../.cargo
       ../assets
       ../Cargo.toml
       ../Cargo.lock
@@ -34,6 +36,7 @@ rustPlatform.buildRustPackage (finalAttrs: {
     YAZI_GEN_COMPLETIONS = true;
     VERGEN_GIT_SHA = rev;
     VERGEN_BUILD_DATE = builtins.concatStringsSep "-" (builtins.match "(.{4})(.{2})(.{2}).*" date);
+    CARGO_NET_OFFLINE = "true";
   };
 
   nativeBuildInputs = [
@@ -45,6 +48,12 @@ rustPlatform.buildRustPackage (finalAttrs: {
     rust-jemalloc-sys
   ];
 
+  buildPhase = ''
+    runHook preBuild
+    cargo xtask build --target ${stdenv.hostPlatform.rust.rustcTarget}
+    runHook postBuild
+  '';
+
   postInstall = ''
     installShellCompletion --cmd yazi \
       --bash ./yazi-boot/completions/yazi.bash \

snap/snapcraft.yaml

@@ -43,7 +43,7 @@ parts:
       - xclip
       - zoxide
     override-build: |
-      craftctl default
+      cargo xtask install --bin-dir "$CRAFT_PART_INSTALL"
       craftctl set version=$(git describe --tags --abbrev=0)
     build-attributes:
       - enable-patchelf

yazi-build/src/build.rs

@@ -1,8 +1,9 @@
-use std::process::Command;
+use std::{env, fs, iter, path::{Path, PathBuf}, process::Command};
 
-use anyhow::{Context, Result};
+use anyhow::{Context, Result, ensure};
+use yazi_macro::ok_or_not_found;
 
-use super::{cargo, is_windows_target, run};
+use super::{cargo, is_linux_target, is_sparc64_target, is_windows_target, run, workspace_root};
 
 pub(super) struct Build {
 	pub(super) target: String,
@@ -33,11 +34,64 @@ impl Build {
 		if self.completions {
 			cmd.env("YAZI_GEN_COMPLETIONS", "1");
 		}
+		if is_linux_target(&self.target) && !is_sparc64_target(&self.target) {
+			self.expose_lld(&mut cmd)?;
+		}
 
 		run(&mut cmd).context("failed to build Yazi")
 	}
 
 	pub(super) fn profile(&self) -> &'static str {
 		if is_windows_target(&self.target) { "release-windows" } else { "release" }
 	}
+
+	fn expose_lld(&self, cmd: &mut Command) -> Result<()> {
+		let rust_lld = Self::rustc_libdir()?
+			.parent()
+			.context("Rust target libdir has no parent")?
+			.join("bin/rust-lld");
+		ensure!(rust_lld.is_file(), "{} does not exist", rust_lld.display());
+
+		let temp_dir = workspace_root()?.join("target/.rust-lld");
+		fs::create_dir_all(&temp_dir).context("failed to create `target/.rust-lld` directory")?;
+		for name in ["ld.lld".to_owned()].into_iter().chain(self.lld_alias()) {
+			let link = temp_dir.join(name);
+			ok_or_not_found!(fs::remove_file(&link));
+			#[cfg(unix)]
+			std::os::unix::fs::symlink(&rust_lld, link)?;
+			#[cfg(not(unix))]
+			anyhow::bail!("bundled rust-lld setup requires a Unix host");
+		}
+
+		let path = env::var_os("PATH").unwrap_or_default();
+		cmd.env("PATH", env::join_paths(iter::once(temp_dir).chain(env::split_paths(&path)))?);
+		Ok(())
+	}
+
+	fn rustc_libdir() -> Result<PathBuf> {
+		let output = Command::new(env::var_os("RUSTC").unwrap_or_else(|| "rustc".into()))
+			.args(["--print", "target-libdir"])
+			.output()
+			.context("failed to locate the Rust target libdir")?;
+
+		ensure!(output.status.success(), "`rustc --print target-libdir` failed");
+		Ok(String::from_utf8(output.stdout)?.trim().into())
+	}
+
+	// Cross GCC resolves `-fuse-ld=lld` as `<toolchain-prefix>ld.lld`.
+	// For example:
+	//   `aarch64-linux-musl-gcc.sh` => `aarch64-linux-musl-ld.lld`
+	// if Cargo has no configured linker:
+	//   `CROSS_TOOLCHAIN_PREFIX=x86_64-linux-musl-` => `x86_64-linux-musl-ld.lld`
+	fn lld_alias(&self) -> Option<String> {
+		let var = env::var_os(format!(
+			"CARGO_TARGET_{}_LINKER",
+			self.target.replace('-', "_").to_ascii_uppercase()
+		))
+		.or_else(|| env::var_os("CROSS_TOOLCHAIN_PREFIX"))?;
+
+		let prefix = Path::new(&var).file_stem()?.to_str()?.trim_end_matches("gcc");
+
+		Some(format!("{prefix}ld.lld"))
+	}
 }

yazi-build/src/common.rs

@@ -29,10 +29,18 @@ pub(super) fn workspace_root() -> Result<PathBuf> {
 		.context("yazi-build must be inside the Yazi workspace")
 }
 
+pub(super) fn is_linux_target(target: &str) -> bool {
+	target.contains("-linux-") || (target.is_empty() && cfg!(target_os = "linux"))
+}
+
 pub(super) fn is_windows_target(target: &str) -> bool {
 	target.contains("-windows-") || (target.is_empty() && cfg!(windows))
 }
 
+pub(super) fn is_sparc64_target(target: &str) -> bool {
+	target.starts_with("sparc64-") || (target.is_empty() && cfg!(target_arch = "sparc64"))
+}
+
 pub(super) fn copy_bins(target: &str, profile: &str, to: &Path) -> Result<()> {
 	let mut from = workspace_root()?.join("target");
 	if !target.is_empty() {