Fix semantic release with @symphonyoss npm org

[jonfreedman]

I've updated package.json but I had to change the NPM_TOKEN in travis to successfully release so deployments are currently done using my account. I don't really care but you may want to change this to use the symphonyoss account that used to do the releases (seems npm have deleted that...)? As I suspected the versioning has reset to 1.0.0 - not sure how to fix that...

See https://www.npmjs.com/package/@symphonyoss/hubot-symphony

Can you look into how to bump the next version to 3.0.7, do a release and notify the dev list that any users need to update their dependencies from hubot-symphony to @symphonyoss\hubot-symphony please?

You may also want this as a reference for future projects.

• Build 280 : failed using npm publish (c81795a)
• Build 281 : pushed to NPM but failed to update github releases - probably due to version mismatch npm publish --access public (e7b506a)

[jonfreedman]

More good news - it looks like the way hubot looks for an adapter is incompatible with organisations. That basically means we need to continue releasing as hubot-symphony or get GitHub to update their code, which given the state of the project seems unlikely.

See https://github.com/github/hubot/blob/master/src/robot.coffee#L482

[maoo]

Using your user NPM_TOKEN is IMO a good approach, since I still keep control over your npm published packages, as I need to add you as team member to grant you "write" access; I will take care of Wiki docs upgrades, specifically these pages:

• https://symphonyoss.atlassian.net/wiki/display/FM/Javascript#Javascript-Publishingonnpm
• https://symphonyoss.atlassian.net/wiki/display/FM/Continuous+Integration#ContinuousIntegration-ContinuousreleaseinNodeJS

Regarding version reset to 1.0.0, I stumbled on a similar issue with @ecarrenho-daitan ; the fix was to re-add version on package.json (in our case with value 3.0.7), run a manual npm publish, then revert the package.json change. I am wondering if the version should be rather 4.0.0, considering that - as you correctly mentioned - the way hubot-symphony coordinates will change for next versions.

Regarding hubot adapters not being compatible with Github organisations; if the adapter is fetched using a package.json dependency, it should have a local path and should be able to load it, right? This is probably the approach I used to run the bot-butler (though I'm not 100% sure). Would this be a problematic/limited approach?

[jonfreedman]

I'll see if I can get a bot working using the @symphonyoss/hubot-symphony 1.0.0 but on my first attempt it didn't work. I see slack have a similar layout, api in the org but adapter outside...

…

---- On Mon, 10 Apr 2017 18:15:23 +0000 notifications@github.com wrote ---- Using your user NPM_TOKEN is IMO a good approach, since I still keep control over your npm published packages, as I need to add you as team member to grant you "write" access; I will take care of Wiki docs upgrades, specifically these pages: https://symphonyoss.atlassian.net/wiki/display/FM/Javascript#Javascript-Publishingonnpm https://symphonyoss.atlassian.net/wiki/display/FM/Continuous+Integration#ContinuousIntegration-ContinuousreleaseinNodeJS Regarding version reset to 1.0.0, I stumbled on a similar issue with @ecarrenho-daitan ; the fix was to re-add version on package.json (in our case with value 3.0.7), run a manual npm publish, then revert the package.json change. I am wondering if the version should be rather 4.0.0, considering that - as you correctly mentioned - the way hubot-symphony coordinates will change for next versions. Regarding hubot adapters not being compatible with Github organisations; if the adapter is fetched using a package.json dependency, it should have a local path and should be able to load it, right? This is probably the approach I used to run the bot-butler (though I'm not 100% sure). Would this be a problematic/limited approach? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[jonfreedman]

I'll leave this open for now, but unless the hubot source code is changed we need to continue to release outside the @symphonyoss organisation

[maoo]

Generated token from ssf-admin user (on npmjs) and updated travis to use it with semantic-release. Documentation is up-to-date on https://symphonyoss.atlassian.net/wiki/display/FM/Javascript