Skip to content

Commit f63467c

Browse files
committed
Reverted observeResize rename
1 parent f137c59 commit f63467c

6 files changed

Lines changed: 20 additions & 20 deletions

File tree

packages/ng-diagram/projects/ng-diagram/src/lib/components/edge-label/base-edge-label/base-edge-label.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export class NgDiagramBaseEdgeLabelComponent implements OnInit, OnDestroy {
120120
positionOnEdge: this.positionOnEdge(),
121121
});
122122

123-
this.batchResizeObserver.observeResize(this.hostElement.nativeElement, {
123+
this.batchResizeObserver.observe(this.hostElement.nativeElement, {
124124
type: 'edge-label',
125125
edgeId: this.edgeId(),
126126
labelId: this.id(),
@@ -139,7 +139,7 @@ export class NgDiagramBaseEdgeLabelComponent implements OnInit, OnDestroy {
139139
}
140140

141141
flowCore.updater.deleteEdgeLabel(this.edgeId(), this.id());
142-
this.batchResizeObserver.unobserveResize(this.hostElement.nativeElement);
142+
this.batchResizeObserver.unobserve(this.hostElement.nativeElement);
143143
}
144144
}
145145

packages/ng-diagram/projects/ng-diagram/src/lib/components/port/ng-diagram-port.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export class NgDiagramPortComponent extends NodeContextGuardBase implements OnIn
171171
side: this.side(),
172172
});
173173

174-
this.batchResizeObserver.observeResize(this.hostElement.nativeElement, {
174+
this.batchResizeObserver.observe(this.hostElement.nativeElement, {
175175
type: 'port',
176176
nodeId: nodeData.id,
177177
portId: this.id(),
@@ -197,7 +197,7 @@ export class NgDiagramPortComponent extends NodeContextGuardBase implements OnIn
197197
return;
198198
}
199199

200-
this.batchResizeObserver.unobserveResize(this.hostElement.nativeElement);
200+
this.batchResizeObserver.unobserve(this.hostElement.nativeElement);
201201

202202
// Skip if node was deleted - ports are removed with the node
203203
const nodeStillExists = flowCore.getNodeById(nodeData.id);

packages/ng-diagram/projects/ng-diagram/src/lib/directives/node-size/node-size.directive.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ describe('NodeSizeDirective', () => {
2222
let element: HTMLElement;
2323

2424
let mockBatchResizeObserver: {
25-
observeResize: ReturnType<typeof vi.fn>;
26-
unobserveResize: ReturnType<typeof vi.fn>;
25+
observe: ReturnType<typeof vi.fn>;
26+
unobserve: ReturnType<typeof vi.fn>;
2727
};
2828

2929
let mockFlowCore: any; // eslint-disable-line @typescript-eslint/no-explicit-any
@@ -33,8 +33,8 @@ describe('NodeSizeDirective', () => {
3333

3434
beforeEach(async () => {
3535
mockBatchResizeObserver = {
36-
observeResize: vi.fn(),
37-
unobserveResize: vi.fn(),
36+
observe: vi.fn(),
37+
unobserve: vi.fn(),
3838
};
3939

4040
mockFlowCore = {
@@ -177,15 +177,15 @@ describe('NodeSizeDirective', () => {
177177

178178
describe('Lifecycle', () => {
179179
it('should connect resize observer on init', () => {
180-
expect(mockBatchResizeObserver.observeResize).toHaveBeenCalledWith(element, {
180+
expect(mockBatchResizeObserver.observe).toHaveBeenCalledWith(element, {
181181
type: 'node',
182182
nodeId: 'test-node',
183183
});
184184
});
185185

186186
it('should disconnect resize observer on destroy', () => {
187187
fixture.destroy();
188-
expect(mockBatchResizeObserver.unobserveResize).toHaveBeenCalledWith(element);
188+
expect(mockBatchResizeObserver.unobserve).toHaveBeenCalledWith(element);
189189
});
190190
});
191191

packages/ng-diagram/projects/ng-diagram/src/lib/directives/node-size/node-size.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,13 +170,13 @@ export class NodeSizeDirective implements OnDestroy, OnInit {
170170
* size-dependent features when nodes resize.
171171
*/
172172
private connectResizeObserver() {
173-
this.batchResizeObserver.observeResize(this.hostElement.nativeElement, {
173+
this.batchResizeObserver.observe(this.hostElement.nativeElement, {
174174
type: 'node',
175175
nodeId: this.id(),
176176
});
177177
}
178178

179179
private disconnectResizeObserver() {
180-
this.batchResizeObserver.unobserveResize(this.hostElement.nativeElement);
180+
this.batchResizeObserver.unobserve(this.hostElement.nativeElement);
181181
}
182182
}

packages/ng-diagram/projects/ng-diagram/src/lib/services/flow-resize-observer/batched-resize-observer.service.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,23 +38,23 @@ describe('BatchResizeObserverService', () => {
3838
vi.restoreAllMocks();
3939
});
4040

41-
describe('observeResize', () => {
41+
describe('observe', () => {
4242
it('should observe an element with metadata', () => {
4343
const el = document.createElement('div');
4444
const metadata: ObservedElementMetadata = { type: 'node', nodeId: 'n1' };
4545

46-
service.observeResize(el, metadata);
46+
service.observe(el, metadata);
4747

4848
expect(mockResizeObserver.observe).toHaveBeenCalledWith(el);
4949
expect(service.getMetadata(el)).toEqual(metadata);
5050
});
5151
});
5252

53-
describe('unobserveResize', () => {
53+
describe('unobserve', () => {
5454
it('should unobserve an element', () => {
5555
const el = document.createElement('div');
5656

57-
service.unobserveResize(el);
57+
service.unobserve(el);
5858

5959
expect(mockResizeObserver.unobserve).toHaveBeenCalledWith(el);
6060
});
@@ -161,7 +161,7 @@ describe('BatchResizeObserverService', () => {
161161
labelId: 'l1',
162162
};
163163

164-
service.observeResize(el, metadata);
164+
service.observe(el, metadata);
165165

166166
expect(service.getMetadata(el)).toEqual(metadata);
167167
});
@@ -172,7 +172,7 @@ describe('BatchResizeObserverService', () => {
172172
const el = document.createElement('div');
173173
const metadata: ObservedElementMetadata = { type: 'port', nodeId: 'n1', portId: 'p1' };
174174

175-
service.observeResize(el, metadata);
175+
service.observe(el, metadata);
176176
mockResizeObserver.observe.mockClear();
177177

178178
service.invalidate(el);

packages/ng-diagram/projects/ng-diagram/src/lib/services/flow-resize-observer/batched-resize-observer.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,15 @@ export class BatchResizeObserverService implements OnDestroy {
7272
/**
7373
* Observe an element's size with metadata via ResizeObserver.
7474
*/
75-
observeResize(element: Element, metadata: ObservedElementMetadata): void {
75+
observe(element: Element, metadata: ObservedElementMetadata): void {
7676
this.observedElements.set(element, metadata);
7777
this.observer?.observe(element);
7878
}
7979

8080
/**
8181
* Stop observing an element's size via ResizeObserver.
8282
*/
83-
unobserveResize(element: Element): void {
83+
unobserve(element: Element): void {
8484
this.observer?.unobserve(element);
8585
// WeakMap automatically handles cleanup
8686
}

0 commit comments

Comments
 (0)