remove create_subscription from sub module

Author: q2w

modules/sub/README.md

@@ -59,7 +59,6 @@ module "sub" {
 |------|-------------|------|---------|:--------:|
 | bigquery\_subscriptions | The list of the Bigquery push subscriptions. | <pre>list(object({<br>    name                       = string,<br>    table                      = string,<br>    use_topic_schema           = optional(bool),<br>    use_table_schema           = optional(bool),<br>    write_metadata             = optional(bool),<br>    drop_unknown_fields        = optional(bool),<br>    ack_deadline_seconds       = optional(number),<br>    retain_acked_messages      = optional(bool),<br>    message_retention_duration = optional(string),<br>    enable_message_ordering    = optional(bool),<br>    expiration_policy          = optional(string),<br>    filter                     = optional(string),<br>    dead_letter_topic          = optional(string),<br>    maximum_backoff            = optional(string),<br>    minimum_backoff            = optional(string)<br>  }))</pre> | `[]` | no |
 | cloud\_storage\_subscriptions | The list of the Cloud Storage push subscriptions. | <pre>list(object({<br>    name                       = string,<br>    bucket                     = string,<br>    filename_prefix            = optional(string),<br>    filename_suffix            = optional(string),<br>    filename_datetime_format   = optional(string),<br>    max_duration               = optional(string),<br>    max_bytes                  = optional(string),<br>    max_messages               = optional(string),<br>    output_format              = optional(string),<br>    write_metadata             = optional(bool),<br>    use_topic_schema           = optional(bool),<br>    ack_deadline_seconds       = optional(number),<br>    retain_acked_messages      = optional(bool),<br>    message_retention_duration = optional(string),<br>    enable_message_ordering    = optional(bool),<br>    expiration_policy          = optional(string),<br>    filter                     = optional(string),<br>    dead_letter_topic          = optional(string),<br>    maximum_backoff            = optional(string),<br>    minimum_backoff            = optional(string)<br>  }))</pre> | `[]` | no |
-| create\_subscriptions | Specify true if you want to create subscriptions. | `bool` | `true` | no |
 | grant\_bigquery\_project\_roles | Specify true if you want to add bigquery.metadataViewer and bigquery.dataEditor roles to the default Pub/Sub SA. | `bool` | `true` | no |
 | grant\_token\_creator | Specify true if you want to add token creator role to the default Pub/Sub SA. | `bool` | `true` | no |
 | project\_id | The project ID to manage the Pub/Sub resources. | `string` | n/a | yes |

modules/sub/main.tf

@@ -82,7 +82,7 @@ resource "google_pubsub_topic_iam_member" "bigquery_topic_binding" {
 }
 
 resource "google_pubsub_subscription_iam_member" "pull_subscription_binding" {
-  for_each = var.create_subscriptions ? { for i in var.pull_subscriptions : i.name => i if i.dead_letter_topic != null } : {}
+  for_each = { for i in var.pull_subscriptions : i.name => i if i.dead_letter_topic != null }
 
   project      = var.project_id
   subscription = each.value.name
@@ -98,7 +98,7 @@ resource "google_pubsub_subscription_iam_member" "pull_subscription_binding" {
 }
 
 resource "google_pubsub_subscription_iam_member" "push_subscription_binding" {
-  for_each = var.create_subscriptions ? { for i in var.push_subscriptions : i.name => i if i.dead_letter_topic != null } : {}
+  for_each = { for i in var.push_subscriptions : i.name => i if i.dead_letter_topic != null }
 
   project      = var.project_id
   subscription = each.value.name
@@ -114,7 +114,7 @@ resource "google_pubsub_subscription_iam_member" "push_subscription_binding" {
 }
 
 resource "google_pubsub_subscription_iam_member" "bigquery_subscription_binding" {
-  for_each = var.create_subscriptions ? { for i in var.bigquery_subscriptions : i.name => i if i.dead_letter_topic != null } : {}
+  for_each = { for i in var.bigquery_subscriptions : i.name => i if i.dead_letter_topic != null }
 
   project      = var.project_id
   subscription = each.value.name
@@ -126,7 +126,7 @@ resource "google_pubsub_subscription_iam_member" "bigquery_subscription_binding"
 }
 
 resource "google_pubsub_subscription" "push_subscriptions" {
-  for_each = var.create_subscriptions ? { for i in var.push_subscriptions : i.name => i } : {}
+  for_each = { for i in var.push_subscriptions : i.name => i }
 
   name                       = each.value.name
   topic                      = var.topic
@@ -181,7 +181,7 @@ resource "google_pubsub_subscription" "push_subscriptions" {
 }
 
 resource "google_pubsub_subscription" "pull_subscriptions" {
-  for_each = var.create_subscriptions ? { for i in var.pull_subscriptions : i.name => i } : {}
+  for_each = { for i in var.pull_subscriptions : i.name => i }
 
   name                         = each.value.name
   topic                        = var.topic
@@ -219,7 +219,7 @@ resource "google_pubsub_subscription" "pull_subscriptions" {
 }
 
 resource "google_pubsub_subscription" "bigquery_subscriptions" {
-  for_each = var.create_subscriptions ? { for i in var.bigquery_subscriptions : i.name => i } : {}
+  for_each = { for i in var.bigquery_subscriptions : i.name => i }
 
   name                       = each.value.name
   topic                      = var.topic
@@ -269,7 +269,7 @@ resource "google_pubsub_subscription" "bigquery_subscriptions" {
 }
 
 resource "google_pubsub_subscription" "cloud_storage_subscriptions" {
-  for_each = var.create_subscriptions ? { for i in var.cloud_storage_subscriptions : i.name => i } : {}
+  for_each = { for i in var.cloud_storage_subscriptions : i.name => i }
 
   name                       = each.value.name
   topic                      = var.topic
@@ -327,7 +327,7 @@ resource "google_pubsub_subscription" "cloud_storage_subscriptions" {
 }
 
 resource "google_pubsub_subscription_iam_member" "pull_subscription_sa_binding_subscriber" {
-  for_each = var.create_subscriptions ? { for i in var.pull_subscriptions : i.name => i if i.service_account != null } : {}
+  for_each = { for i in var.pull_subscriptions : i.name => i if i.service_account != null }
 
   project      = var.project_id
   subscription = each.value.name
@@ -343,7 +343,7 @@ resource "google_pubsub_subscription_iam_member" "pull_subscription_sa_binding_s
 }
 
 resource "google_pubsub_subscription_iam_member" "pull_subscription_sa_binding_viewer" {
-  for_each = var.create_subscriptions ? { for i in var.pull_subscriptions : i.name => i if i.service_account != null } : {}
+  for_each = { for i in var.pull_subscriptions : i.name => i if i.service_account != null }
 
   project      = var.project_id
   subscription = each.value.name

modules/sub/metadata.yaml

@@ -58,10 +58,6 @@ spec:
         description: The Pub/Sub topic name.
         varType: string
         required: true
-      - name: create_subscriptions
-        description: Specify true if you want to create subscriptions.
-        varType: bool
-        defaultValue: true
       - name: push_subscriptions
         description: The list of the push subscriptions.
         varType: |-

modules/sub/variables.tf

@@ -24,12 +24,6 @@ variable "topic" {
   description = "The Pub/Sub topic name."
 }
 
-variable "create_subscriptions" {
-  type        = bool
-  description = "Specify true if you want to create subscriptions."
-  default     = true
-}
-
 variable "push_subscriptions" {
   type = list(object({
     name                       = string,