Skip to content

Change HidingContainer Validation Behavior #8

@ghost

Description

I notice that when a field is in the hidden state (not displayed on the form), that HidingContainerMixin._validate automatically sets this value to None. I would think that if a field is hidden in a form it is because you don't want that data to even be considered by the server side. This has led to nasty errors like fields in the database being set to null when this wasn't actually specified in the form. Does it make sense to just not set data[c.id] if the field is hdden? Let me know if you there is a reson for doing this.

See line 142 in tw2.dynforms.widgets.py
if c.id in self.hiding_ctrls and c.id not in show:
data[c.id] = None

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions