test(datastore): surface sqlDB.Close() errors in test cleanup

Replace `_ = sqlDB.Close()` with `require.NoError(t, sqlDB.Close())`
across all four repository test files so leaked handles are surfaced
during parallel test runs.

Author: tphakala

internal/datastore/v2/repository/alert_rule_impl_test.go

@@ -25,7 +25,7 @@ func setupAlertTestDB(t *testing.T) *gorm.DB {
 	sqlDB, err := db.DB()
 	require.NoError(t, err, "failed to get sql.DB")
 	sqlDB.SetMaxOpenConns(1)
-	t.Cleanup(func() { _ = sqlDB.Close() })
+	t.Cleanup(func() { require.NoError(t, sqlDB.Close(), "failed to close test database") })
 
 	err = db.AutoMigrate(
 		&entities.AlertRule{},

internal/datastore/v2/repository/app_metadata_test.go

@@ -24,7 +24,7 @@ func setupAppMetadataTestDB(t *testing.T) *gorm.DB {
 
 	sqlDB, err := db.DB()
 	require.NoError(t, err, "failed to get sql.DB")
-	t.Cleanup(func() { _ = sqlDB.Close() })
+	t.Cleanup(func() { require.NoError(t, sqlDB.Close(), "failed to close test database") })
 
 	err = db.AutoMigrate(&entities.AppMetadata{})
 	require.NoError(t, err, "failed to migrate app_metadata table")

internal/datastore/v2/repository/audio_source_impl_test.go

@@ -24,7 +24,7 @@ func setupAudioSourceTestDB(t *testing.T) *gorm.DB {
 
 	sqlDB, err := db.DB()
 	require.NoError(t, err, "failed to get sql.DB")
-	t.Cleanup(func() { _ = sqlDB.Close() })
+	t.Cleanup(func() { require.NoError(t, sqlDB.Close(), "failed to close test database") })
 
 	err = db.AutoMigrate(&entities.AudioSource{})
 	require.NoError(t, err, "failed to migrate audio_sources table")

internal/datastore/v2/repository/insights_impl_test.go

@@ -24,7 +24,7 @@ func setupInsightsTestDB(t *testing.T) *gorm.DB {
 	sqlDB, err := db.DB()
 	require.NoError(t, err)
 	sqlDB.SetMaxOpenConns(1)
-	t.Cleanup(func() { _ = sqlDB.Close() })
+	t.Cleanup(func() { require.NoError(t, sqlDB.Close(), "failed to close test database") })
 
 	err = db.AutoMigrate(
 		&entities.LabelType{},