build_node not implemented for onnx_ir::processor::DefaultProcessor

[raphaelmenges]

Hello 👋,

I followed the burn book to import my ONNX model in burn = "0.20.0-pre.6", burn-import = "0.20.0-pre.6". It looks like all operators are supported, but in a late phase of cargo build the following (weird?) error is spawned:

DEBUG onnx_ir::pipeline:  PHASE 6: Node Conversion (RawNode -> Node)
DEBUG onnx_ir::ir::graph: Converting node 'resize1' of type Resize
DEBUG onnx_ir::ir::graph: Converting node 'constant157' of type Constant
DEBUG onnx_ir::ir::graph: Converting node 'sub1' of type Sub
DEBUG onnx_ir::ir::graph: Converting node 'constant158' of type Constant
DEBUG onnx_ir::ir::graph: Converting node 'div1' of type Div
DEBUG onnx_ir::ir::graph: Converting node 'conv2d1' of type Conv2d
DEBUG onnx_ir::ir::graph: Converting node 'hardswish1' of type HardSwish
ERROR burn_import::logger: PANIC => panicked at /Users/raphael/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/onnx-ir-0.20.0-pre.6/src/processor.rs:233:9:
  build_node not implemented for onnx_ir::processor::DefaultProcessor - each processor must implement this method

I think the error message should actually contain a node type?

I am wondering whether I need to just enable a feature or miss something else obvious?

[laggui]

Looks like one of the operations in your model might not be entirely implemented 🤔 Though I agree, the message should be more clear.

Is the model publicly available? So we can debug the issue

[raphaelmenges]

Sure, I created a minimal repository so you can reproduce the issue: https://github.com/raphaelmenges/rvm-burn/tree/main

[laggui]

If you try building again it should fetch the newly released 0.20 version, which added support for HardSwish. It no longer fails with the previous error, but now builds up to:

  DEBUG burn_import::burn::graph: Registering node => 'clip2'
  DEBUG burn_import::burn::graph: Building the scope nodes len => '292'
  ERROR burn_import::logger: PANIC => panicked at /home/laggui/workspace/burn-refactor/crates/burn-import/src/burn/node/resize.rs:175:22:
  Runtime resize requires sizes input

That looks like a bug / limitation with the current resize import. It appears it only checks for sizes but not scales (which should also be supported).

[raphaelmenges]

Thanks for the update @laggui! Shall I create a proper issue or are you tracking it? We could add the model to https://github.com/tracel-ai/burn/issues/3412

[laggui]

Just opened an issue to track it!

[raphaelmenges]

For reference: tracel-ai/burn-onnx#3

[raphaelmenges]

I guess the fix will be part of burn-import in version v0.21.0-pre.1? If so, I am happy to verify whether the model now loads successfully, once that version has been released!