Skip to content

Commit 598fc8e

Browse files
samejrclaude
andcommitted
Restore Private Connections / Roles sidebar guards
The hasPrivateConnections feature-flag guard and the isUsingPlugin guard for Roles were commented out in a80dd96 (WIP cleanup) and never re-enabled. Route loaders still defend against unauthorised access (the Private Connections loader redirects, Roles renders an upsell empty state) but exposing both items unconditionally to users without the entitlements is a UX regression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0ffc6b2 commit 598fc8e

1 file changed

Lines changed: 20 additions & 20 deletions

File tree

apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -121,26 +121,26 @@ export function OrganizationSettingsSideMenu({
121121
to={organizationTeamPath(organization)}
122122
data-action="team"
123123
/>
124-
{/* {isUsingPlugin && ( */}
125-
{/* {featureFlags.hasPrivateConnections && ( */}
126-
<SideMenuItem
127-
name="Private Connections"
128-
icon={PadlockIcon}
129-
activeIconColor="text-text-bright"
130-
inactiveIconColor="text-text-dimmed"
131-
to={v3PrivateConnectionsPath(organization)}
132-
data-action="private-connections"
133-
/>
134-
{/* )} */}
135-
<SideMenuItem
136-
name="Roles"
137-
icon={RolesIcon}
138-
activeIconColor="text-text-bright"
139-
inactiveIconColor="text-text-dimmed"
140-
to={organizationRolesPath(organization)}
141-
data-action="roles"
142-
/>
143-
{/* )} */}
124+
{featureFlags.hasPrivateConnections && (
125+
<SideMenuItem
126+
name="Private Connections"
127+
icon={PadlockIcon}
128+
activeIconColor="text-text-bright"
129+
inactiveIconColor="text-text-dimmed"
130+
to={v3PrivateConnectionsPath(organization)}
131+
data-action="private-connections"
132+
/>
133+
)}
134+
{isUsingPlugin && (
135+
<SideMenuItem
136+
name="Roles"
137+
icon={RolesIcon}
138+
activeIconColor="text-text-bright"
139+
inactiveIconColor="text-text-dimmed"
140+
to={organizationRolesPath(organization)}
141+
data-action="roles"
142+
/>
143+
)}
144144
<SideMenuItem
145145
name="Settings"
146146
icon={SlidersIcon}

0 commit comments

Comments
 (0)