chore(lint): enable additional dcm rules and update dependencies

- Enable shorthand preference rules that were previously disabled
- Enable new metrics rules: avoid-missing-test-files,
  avoid-unassigned-local-variable, avoid-undisposed-instances,
  avoid-unnecessary-parentheses, prefer-non-nulls
- Disable avoid-throw rule due to breaking change and use of maybe*
  methods
- Update dart_code_metrics_presets to ^2.30.0
- Update test to ^1.31.0
- Update SDK constraint to ^3.11.3
- Fix RegExp instantiation to use shorthand syntax
- Update example code to use maybeMapStatusCode with proper parameter
  handling

Author: tsinis

analysis_options.yaml

@@ -122,17 +122,12 @@ dart_code_metrics:
         min-occurrences: 4
 
     # Disabled:
-    # Shorthands:
-    - prefer-returning-shorthands: false
-    - prefer-shorthands-with-constructors: false
-    - prefer-shorthands-with-enums: false
-    - prefer-shorthands-with-static-fields: false
-    # Other disabled:
     - arguments-ordering: false # This will be a breaking change.
     - avoid-continue: false # Just a matter of style.
     - avoid-deprecated-usage: false # Using default deprecated_member_use_from_same_package.
     - avoid-inferrable-type-arguments: false # Against prefer-explicit-type-arguments.
     - avoid-long-files: false # A lot of data and collections.
+    - avoid-throw: false # Breaking change + we have maybe* methods.
     - no-magic-number: false # Packages contain a lot of numbers.
     - no-magic-string: false # Packages contain a lot of strings.
     - parameters-ordering: false # This will be a breaking change.
@@ -218,6 +213,7 @@ dart_code_metrics:
     - avoid-missing-completer-stack-trace: true
     - avoid-missing-enum-constant-in-map: true
     - avoid-missing-interpolation: true
+    - avoid-missing-test-files: true
     - avoid-misused-set-literals: true
     - avoid-misused-test-matchers: true
     - avoid-misused-wildcard-pattern: true
@@ -276,9 +272,11 @@ dart_code_metrics:
     - avoid-type-casts: true
     - avoid-unassigned-fields: true
     - avoid-unassigned-late-fields: true
+    - avoid-unassigned-local-variable: true
     - avoid-unassigned-stream-subscriptions: true
     - avoid-uncaught-future-errors: true
     - avoid-unconditional-break: true
+    - avoid-undisposed-instances: true
     - avoid-unknown-pragma: true
     - avoid-unnecessary-block: true
     - avoid-unnecessary-call: true
@@ -304,6 +302,7 @@ dart_code_metrics:
     - avoid-unnecessary-nullable-parameters: true
     - avoid-unnecessary-nullable-return-type: true
     - avoid-unnecessary-overrides: true
+    - avoid-unnecessary-parentheses: true
     - avoid-unnecessary-patterns: true
     - avoid-unnecessary-reassignment: true
     - avoid-unnecessary-return: true
@@ -401,6 +400,7 @@ dart_code_metrics:
     - prefer-match-file-name: true
     - prefer-moving-to-variable: true
     - prefer-named-boolean-parameters: true
+    - prefer-non-nulls: true
     - prefer-null-aware-elements: true
     - prefer-null-aware-spread: true
     - prefer-overriding-parent-equality: true
@@ -413,6 +413,10 @@ dart_code_metrics:
     - prefer-return-await: true
     - prefer-returning-condition: true
     - prefer-returning-conditional-expressions: true
+    - prefer-returning-shorthands: true
+    - prefer-shorthands-with-constructors: true
+    - prefer-shorthands-with-enums: true
+    - prefer-shorthands-with-static-fields: true
     - prefer-simpler-boolean-expressions: true
     - prefer-simpler-patterns-null-check: true
     - prefer-single-declaration-per-file: true
@@ -658,4 +662,4 @@ linter:
     use_to_and_as_if_applicable: true
     use_truncating_division: true
     valid_regexps: true
-    void_checks: true
+    void_checks: true

example/analysis_options.yaml

@@ -1 +1 @@
-include: ../analysis_options.yaml
+include: ../analysis_options.yaml

example/lib/main.dart

@@ -85,14 +85,13 @@ Future<int?> _realClient(List<String> arguments, [http.Client? client]) async {
 
   // If the status code is a success status code, check if it is a 201
   // (Created) or 200 (OK) code.
-  return response.statusCode.maybeWhenStatusCode(
-    isSuccess: () {
+  return response.statusCode.maybeMapStatusCode(
+    isSuccess: (successStatus) {
       // If the status code is success one, convert it to a registered
       // status code object.
-      final registeredCode = response.statusCode.toRegisteredStatusCode();
+      final registeredCode = successStatus.toRegisteredStatusCode();
 
-      // Use the [StatusCode] type to determine the specific status code
-      // type.
+      // Use the [StatusCode] type to determine the specific status code type.
       return registeredCode?.maybeMap(
             createdHttp201: (status) {
               print('Response has registered success status but not 200 code');
@@ -114,17 +113,24 @@ Future<int?> _realClient(List<String> arguments, [http.Client? client]) async {
               print('Response has success status but not 200 code');
 
               // Return the status code.
-              return response.statusCode;
+              return successStatus;
             },
           ) ??
           // If the status code is not a registered status code, return the
           // status code.
-          response.statusCode;
+          successStatus;
     },
-    orElse: () {
+    isClientError: (errorStatus) {
+      if (errorStatus.isOneOf(const [StatusCode.tooManyRequestsHttp429])) {
+        print('Response has too many requests status :(');
+      }
+
+      return errorStatus; // Return the status code.
+    },
+    orElse: (otherStatus) {
       // If the status code is not a success status code, print an error
       // message and return the status code.
-      print('Request failed with status: ${response.statusCode}!');
+      print('Request failed with status: $otherStatus!');
 
       return response.statusCode;
     },

example/pubspec.yaml

@@ -3,14 +3,14 @@ description: A simple one and modified http package example with use of function
 publish_to: none
 
 environment:
-  sdk: ^3.11.1
+  sdk: ^3.11.3
 
 dependencies:
   functional_status_codes:
     path: ../
   http: any # ignore: avoid-any-version, it's exampe app.
 
 dev_dependencies:
-  dart_code_metrics_presets: ^2.29.0 # DCM.
+  dart_code_metrics_presets: ^2.30.0 # DCM.
   lints: ^6.1.0 # From Google.
-  test: ^1.30.0 # From Google.
+  test: ^1.31.0 # From Google.

lib/src/status_code.dart

@@ -734,7 +734,7 @@ extension type const StatusCode._(int _code) implements int {
   /// See also:
   /// - [pattern], the raw regular expression string this getter utilizes.
   /// - [StatusCode], which contains standard HTTP status codes.
-  static RegExp get regExp => RegExp(pattern, caseSensitive: false);
+  static RegExp get regExp => .new(pattern, caseSensitive: false);
 
   /// Returns the [StatusCode] type value for the given status code, if it
   /// exists. Otherwise, returns `null`.

pubspec.yaml

@@ -20,6 +20,6 @@ environment:
 
 dev_dependencies:
   coverage: ^1.15.0 # From Google.
-  dart_code_metrics_presets: ^2.29.0 # DCM.
+  dart_code_metrics_presets: ^2.30.0 # DCM.
   lints: ^6.1.0 # From Google.
-  test: ^1.30.0 # From Google.
+  test: ^1.31.0 # From Google.