Skip to content

Commit d99f7fa

Browse files
committed
Update versions in CI, make tests work with Ruby 3.4
1 parent ec2190a commit d99f7fa

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

.github/workflows/ci-build-and-install-gem.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ on:
66

77
jobs:
88
build:
9-
runs-on: ubuntu-22.04
9+
runs-on: ubuntu-latest
1010

1111
steps:
1212
- name: Checkout code
13-
uses: actions/checkout@v3
13+
uses: actions/checkout@v6
1414

1515
- name: Setup Ruby
1616
uses: ruby/setup-ruby@v1
1717
with:
18-
ruby-version: 3.1.2
18+
ruby-version: ruby
1919

2020
- name: Build and install gem
2121
run: gem build *.gemspec && gem install *.gem

.github/workflows/ci.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66

77
jobs:
88
build:
9-
runs-on: ubuntu-22.04
9+
runs-on: ubuntu-latest
1010

1111
strategy:
1212
fail-fast: false
@@ -17,13 +17,15 @@ jobs:
1717
- { ruby: '3.0' }
1818
- { ruby: '3.1' }
1919
- { ruby: '3.2' }
20+
- { ruby: '3.3' }
21+
- { ruby: '3.4' }
2022
- { ruby: head, allow-failure: true }
21-
- { ruby: jruby-9.3 }
23+
- { ruby: jruby-10.0 }
2224
- { ruby: jruby-head, allow-failure: true }
2325

2426
steps:
2527
- name: Checkout code
26-
uses: actions/checkout@v3
28+
uses: actions/checkout@v6
2729

2830
- name: Setup Ruby ${{ matrix.ruby }}
2931
uses: ruby/setup-ruby@v1

spec/lib/twingly/url_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def leading_and_trailing_whitespace
220220
context "when called from the outside" do
221221
it "raises an error" do
222222
expect { described_class.internal_parse("a") }.
223-
to raise_error(NoMethodError, /private method `internal_parse' called for/)
223+
to raise_error(NoMethodError, /private method (`|')internal_parse' called for/)
224224
end
225225
end
226226
end
@@ -229,7 +229,7 @@ def leading_and_trailing_whitespace
229229
context "when called from the outside" do
230230
it "raises an error" do
231231
expect { described_class.new("a", "b") }.
232-
to raise_error(NoMethodError, /private method `new' called for/)
232+
to raise_error(NoMethodError, /private method (`|')new' called for/)
233233
end
234234
end
235235
end

0 commit comments

Comments
 (0)