Skip to content

Commit 7e8d229

Browse files
author
David Crow
committed
Fix prep workflow
1 parent d5d4362 commit 7e8d229

1 file changed

Lines changed: 29 additions & 12 deletions

File tree

scripts/lib/version_utils.sh

Lines changed: 29 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ sedi() {
1111
}
1212

1313
# Determine bump type (major, minor, patch)
14+
# Properly compares semver: only checks minor if major is equal, only checks patch if both are equal
1415
determine_bump_type() {
1516
local old=$1
1617
local new=$2
@@ -20,10 +21,18 @@ determine_bump_type() {
2021

2122
if [ "$new_major" -gt "$old_major" ]; then
2223
echo "major"
23-
elif [ "$new_minor" -gt "$old_minor" ]; then
24-
echo "minor"
25-
elif [ "$new_patch" -gt "$old_patch" ]; then
26-
echo "patch"
24+
elif [ "$new_major" -eq "$old_major" ]; then
25+
if [ "$new_minor" -gt "$old_minor" ]; then
26+
echo "minor"
27+
elif [ "$new_minor" -eq "$old_minor" ]; then
28+
if [ "$new_patch" -gt "$old_patch" ]; then
29+
echo "patch"
30+
else
31+
echo "none"
32+
fi
33+
else
34+
echo "none"
35+
fi
2736
else
2837
echo "none"
2938
fi
@@ -128,8 +137,8 @@ get_proxy_version_from_release() {
128137
fi
129138
}
130139

131-
# Determine plugin bump type based on proxy major version change
132-
# Compares proxy version at plugin's last release vs current proxy version
140+
# Determine plugin bump type based on proxy version change
141+
# Properly compares semver: only checks minor if major is equal, only checks patch if both are equal
133142
# Args: $1 = old proxy version, $2 = new proxy version
134143
determine_plugin_bump_type() {
135144
local old_proxy="$1"
@@ -141,12 +150,20 @@ determine_plugin_bump_type() {
141150
# Major version change in proxy = major bump for plugin
142151
if [ "$new_major" -gt "$old_major" ]; then
143152
echo "major"
144-
# Minor version change in proxy = minor bump for plugin
145-
elif [ "$new_minor" -gt "$old_minor" ]; then
146-
echo "minor"
147-
# Patch version change in proxy = patch bump for plugin
148-
elif [ "$new_patch" -gt "$old_patch" ]; then
149-
echo "patch"
153+
elif [ "$new_major" -eq "$old_major" ]; then
154+
# Minor version change in proxy = minor bump for plugin
155+
if [ "$new_minor" -gt "$old_minor" ]; then
156+
echo "minor"
157+
elif [ "$new_minor" -eq "$old_minor" ]; then
158+
# Patch version change in proxy = patch bump for plugin
159+
if [ "$new_patch" -gt "$old_patch" ]; then
160+
echo "patch"
161+
else
162+
echo "none"
163+
fi
164+
else
165+
echo "none"
166+
fi
150167
else
151168
echo "none"
152169
fi

0 commit comments

Comments
 (0)