Fix UIViewControllerHierarchyInconsistency crash in AirshipEmbeddedViewWrapper#732
Merged
Fix UIViewControllerHierarchyInconsistency crash in AirshipEmbeddedViewWrapper#732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When AirshipEmbeddedViewWrapper is removed from the window, properly removes the hosted UIHostingController as a child VC before detaching. Also changes parentViewController() to return an optional instead of force-unwrapping.
Why are these changes necessary?
UIHostingController was added as a child VC but never removed on window detach. On the next navigation that re-added it, UIKit threw UIViewControllerHierarchyInconsistency.
How did you verify these changes?
10+ stack push/pop cycles on a screen with an embedded view - no crash with the fix in place.
Verification Screenshots:
Anything else a reviewer should know?
Tab switching doesn't trigger didMoveToWindow(nil) - only stack push/pop does. Test with a stack navigator, not tabs.