Add lazy factories for remaining instruments

Author: ChiragAgg5k

src/Telemetry/Histogram.php

@@ -4,6 +4,48 @@
 
 abstract class Histogram
 {
+    /**
+     * @param array<string, mixed> $advisory
+     */
+    public static function lazy(
+        Adapter $telemetry,
+        string $name,
+        ?string $unit = null,
+        ?string $description = null,
+        array $advisory = [],
+    ): self {
+        return new class ($telemetry, $name, $unit, $description, $advisory) extends Histogram {
+            private ?Histogram $inner = null;
+
+            /**
+             * @param array<string, mixed> $advisory
+             */
+            public function __construct(
+                private Adapter $telemetry,
+                private string $name,
+                private ?string $unit,
+                private ?string $description,
+                private array $advisory,
+            ) {
+            }
+
+            /**
+             * @param iterable<non-empty-string, array<mixed>|bool|float|int|string|null> $attributes
+             */
+            public function record(float|int $amount, iterable $attributes = []): void
+            {
+                $this->inner ??= $this->telemetry->createHistogram(
+                    $this->name,
+                    $this->unit,
+                    $this->description,
+                    $this->advisory,
+                );
+
+                $this->inner->record($amount, $attributes);
+            }
+        };
+    }
+
     /**
      * @param iterable<non-empty-string, array<mixed>|bool|float|int|string|null> $attributes
      */

src/Telemetry/UpDownCounter.php

@@ -4,6 +4,48 @@
 
 abstract class UpDownCounter
 {
+    /**
+     * @param array<string, mixed> $advisory
+     */
+    public static function lazy(
+        Adapter $telemetry,
+        string $name,
+        ?string $unit = null,
+        ?string $description = null,
+        array $advisory = [],
+    ): self {
+        return new class ($telemetry, $name, $unit, $description, $advisory) extends UpDownCounter {
+            private ?UpDownCounter $inner = null;
+
+            /**
+             * @param array<string, mixed> $advisory
+             */
+            public function __construct(
+                private Adapter $telemetry,
+                private string $name,
+                private ?string $unit,
+                private ?string $description,
+                private array $advisory,
+            ) {
+            }
+
+            /**
+             * @param iterable<non-empty-string, array<mixed>|bool|float|int|string|null> $attributes
+             */
+            public function add(float|int $amount, iterable $attributes = []): void
+            {
+                $this->inner ??= $this->telemetry->createUpDownCounter(
+                    $this->name,
+                    $this->unit,
+                    $this->description,
+                    $this->advisory,
+                );
+
+                $this->inner->add($amount, $attributes);
+            }
+        };
+    }
+
     /**
      * @param iterable<non-empty-string, array<mixed>|bool|float|int|string|null> $attributes
      */

tests/Telemetry/LazyInstrumentTest.php

@@ -6,6 +6,8 @@
 use Utopia\Telemetry\Adapter\Test;
 use Utopia\Telemetry\Counter;
 use Utopia\Telemetry\Gauge;
+use Utopia\Telemetry\Histogram;
+use Utopia\Telemetry\UpDownCounter;
 
 class LazyInstrumentTest extends TestCase
 {
@@ -46,4 +48,42 @@ public function testLazyGaugeCreatesInnerGaugeOnFirstRecord(): void
         $this->assertSame($inner, $telemetry->gauges['event.timestamp']);
         $this->assertSame([123.45, 456.78], $telemetry->gauges['event.timestamp']->values);
     }
+
+    public function testLazyHistogramCreatesInnerHistogramOnFirstRecord(): void
+    {
+        $telemetry = new Test();
+        $histogram = Histogram::lazy($telemetry, 'request.duration', 'ms', 'Request duration');
+
+        $this->assertSame([], $telemetry->histograms);
+
+        $histogram->record(12.3, ['route' => '/v1/health']);
+
+        $this->assertArrayHasKey('request.duration', $telemetry->histograms);
+        $this->assertSame([12.3], $telemetry->histograms['request.duration']->values);
+
+        $inner = $telemetry->histograms['request.duration'];
+        $histogram->record(45.6);
+
+        $this->assertSame($inner, $telemetry->histograms['request.duration']);
+        $this->assertSame([12.3, 45.6], $telemetry->histograms['request.duration']->values);
+    }
+
+    public function testLazyUpDownCounterCreatesInnerCounterOnFirstAdd(): void
+    {
+        $telemetry = new Test();
+        $counter = UpDownCounter::lazy($telemetry, 'active.requests', '{request}', 'Active requests');
+
+        $this->assertSame([], $telemetry->upDownCounters);
+
+        $counter->add(1, ['route' => '/v1/health']);
+
+        $this->assertArrayHasKey('active.requests', $telemetry->upDownCounters);
+        $this->assertSame([1], $telemetry->upDownCounters['active.requests']->values);
+
+        $inner = $telemetry->upDownCounters['active.requests'];
+        $counter->add(-1);
+
+        $this->assertSame($inner, $telemetry->upDownCounters['active.requests']);
+        $this->assertSame([1, -1], $telemetry->upDownCounters['active.requests']->values);
+    }
 }