Merge pull request #3686 from verifywise-ai/hp-apr-7-fix-nist-ai-bug

Fix nist ai UI render bug

Author: gorkem-bwl

.claude/settings.local.json

@@ -11,7 +11,8 @@
       "Bash(find /Users/harsh/Data/vw/verifywise/Clients -type f \\\\\\(-name *.yaml -o -name *.yml -o -name docker-compose* \\\\\\))",
       "Bash(find /Users/harsh/Data/vw/verifywise -type f \\\\\\(-name *.yaml -o -name *.yml -o -name docker-compose* \\\\\\) -not -path */node_modules/*)",
       "Bash(grep -r \"superadmin\\\\|super.admin\\\\|SuperAdmin\" /Users/harsh/Data/vw/verifywise/Servers/src --include=*.ts -i)",
-      "Bash(grep:*)"
+      "Bash(grep:*)",
+      "Bash(git log:*)"
     ]
   }
 }

Clients/src/presentation/components/EntityLinkSelector/index.tsx

@@ -362,24 +362,24 @@ const EntityLinkSelector: React.FC<EntityLinkSelectorProps> = ({
             const nistData = nistResponse?.data || nistResponse;
             const functions = nistData?.functions || [];
             functions.forEach((func: any) => {
-              const funcData = func.dataValues || func;
-              const funcType = funcData.type?.toUpperCase() || "FUNCTION";
-              const categories = funcData.categories || [];
+              const funcType = (func.function || "FUNCTION").toUpperCase();
+              const categories = func.categories || [];
               categories.forEach((cat: any, catIndex: number) => {
-                const catData = cat.dataValues || cat;
-                const subcategories = catData.subcategories || [];
+                const subcategories = cat.subcategories || [];
                 // Always use function type + category index for unique category label
                 const categoryLabel = `${funcType} ${catIndex + 1}`;
                 subcategories.forEach((sub: any, subIndex: number) => {
-                  const subData = sub.dataValues || sub;
-                  const subTitle = subData.title || "";
-                  // Format: "GOVERN 1.1: Description..." or just "GOVERN 1.1" if no title
+                  // Skip subcategories that have no implementation record yet —
+                  // the backend returns id: 0 for those, which would collide.
+                  if (!sub.id) return;
+                  const subTitle = sub.description || "";
+                  // Format: "GOVERN 1.1: Description..." or just "GOVERN 1.1" if no description
                   const subLabel = subTitle
                     ? `${categoryLabel}.${subIndex + 1}: ${subTitle.substring(0, 60)}${subTitle.length > 60 ? "..." : ""}`
                     : `${categoryLabel}.${subIndex + 1}`;
                   subEntityList.push({
-                    _id: `nist_subcategory_${subData.id}`,
-                    entity_id: subData.id,
+                    _id: `nist_subcategory_${sub.id}`,
+                    entity_id: sub.id,
                     name: subLabel,
                     type: "nist_subcategory",
                   });

Clients/src/presentation/pages/Framework/Dashboard/NISTFunctionsOverviewCard.tsx

@@ -24,20 +24,21 @@ interface NISTFunctionsOverviewCardProps {
 
 interface SubcategoryData {
   id: number;
-  title: string;
+  subcategory_id: number;
+  description: string;
   status: string;
   owner: number | null;
 }
 
 interface CategoryData {
   id: number;
-  title: string;
+  category_id: number;
+  description: string;
   subcategories: SubcategoryData[];
 }
 
 interface FunctionData {
-  id: number;
-  type: string;
+  function: string;
   title: string;
   icon: LucideIcon;
   categories: CategoryData[];
@@ -81,10 +82,9 @@ const NISTFunctionsOverviewCard = ({ frameworksData, onNavigate }: NISTFunctions
 
         if (overviewResponse?.data?.functions) {
           const functions = overviewResponse.data.functions.map((func: any) => ({
-            id: func.id,
-            type: func.type,
+            function: func.function,
             title: func.title,
-            icon: NIST_FUNCTION_ICONS[func.type?.toLowerCase()] || Shield,
+            icon: NIST_FUNCTION_ICONS[func.function?.toLowerCase()] || Shield,
             categories: func.categories || [],
           }));
           setFunctionsData(functions);
@@ -187,7 +187,7 @@ const NISTFunctionsOverviewCard = ({ frameworksData, onNavigate }: NISTFunctions
 
     const handleCardClick = () => {
       if (onNavigate) {
-        onNavigate("NIST AI RMF", func.type.toLowerCase());
+        onNavigate("NIST AI RMF", func.function.toLowerCase());
       }
     };
 
@@ -223,7 +223,7 @@ const NISTFunctionsOverviewCard = ({ frameworksData, onNavigate }: NISTFunctions
                 textTransform: "capitalize",
               }}
             >
-              {func.type}
+              {func.title}
             </Typography>
           </Box>
           {onNavigate && (
@@ -313,10 +313,10 @@ const NISTFunctionsOverviewCard = ({ frameworksData, onNavigate }: NISTFunctions
   };
 
   // Get functions by type for 2x2 grid layout
-  const governFunc = functionsData.find(f => f.type.toLowerCase() === "govern");
-  const mapFunc = functionsData.find(f => f.type.toLowerCase() === "map");
-  const measureFunc = functionsData.find(f => f.type.toLowerCase() === "measure");
-  const manageFunc = functionsData.find(f => f.type.toLowerCase() === "manage");
+  const governFunc = functionsData.find(f => f.function?.toLowerCase() === "govern");
+  const mapFunc = functionsData.find(f => f.function?.toLowerCase() === "map");
+  const measureFunc = functionsData.find(f => f.function?.toLowerCase() === "measure");
+  const manageFunc = functionsData.find(f => f.function?.toLowerCase() === "manage");
 
   return (
     <Stack spacing={0}>

docker-compose.prod.yml

@@ -17,7 +17,7 @@ services:
 
   frontend:
     ports:
-      - $FRONTEND_PORT:80
+      - "127.0.0.1:${FRONTEND_PORT}:80"
     env_file:
       - ./.env.prod