Skip to content

Commit bd9b747

Browse files
committed
refactor(logging): standardize eventType in failure logs as 'Error'
- Replaced specific eventType values ("Read", "Delete") with a unified "Error" type for consistency. - Updated `listFiles`, `downloadFile`, and `removeFile` functions to ensure uniform logging structure.
1 parent 40d146f commit bd9b747

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Servers/controllers/fileManager.ctrl.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ export const listFiles = async (req: Request, res: Response): Promise<any> => {
332332

333333
} catch (error) {
334334
await logFailure({
335-
eventType: "Read",
335+
eventType: "Error",
336336
description: "Failed to retrieve file list",
337337
functionName: "listFiles",
338338
fileName: "fileManager.ctrl.ts",
@@ -432,7 +432,7 @@ export const downloadFile = async (req: Request, res: Response): Promise<any> =>
432432
await fs.promises.access(filePath, fs.constants.F_OK);
433433
} catch (error) {
434434
await logFailure({
435-
eventType: "Read",
435+
eventType: "Error",
436436
description: `File not found on disk: ${filePath}. Database record exists but file is missing.`,
437437
functionName: "downloadFile",
438438
fileName: "fileManager.ctrl.ts",
@@ -539,7 +539,7 @@ export const removeFile = async (req: Request, res: Response): Promise<any> => {
539539

540540
if (!file) {
541541
await logFailure({
542-
eventType: "Delete",
542+
eventType: "Error",
543543
description: `File not found: ID ${fileId}`,
544544
functionName: "removeFile",
545545
fileName: "fileManager.ctrl.ts",
@@ -584,7 +584,7 @@ export const removeFile = async (req: Request, res: Response): Promise<any> => {
584584

585585
if (!deleted) {
586586
await logFailure({
587-
eventType: "Delete",
587+
eventType: "Error",
588588
description: `File not found during deletion: ID ${fileId}`,
589589
functionName: "removeFile",
590590
fileName: "fileManager.ctrl.ts",
@@ -609,7 +609,7 @@ export const removeFile = async (req: Request, res: Response): Promise<any> => {
609609
);
610610
} catch (error) {
611611
await logFailure({
612-
eventType: "Delete",
612+
eventType: "Error",
613613
description: "Failed to delete file",
614614
functionName: "removeFile",
615615
fileName: "fileManager.ctrl.ts",

0 commit comments

Comments
 (0)