chore: address merge request suggestions

Signed-off-by: Rai Siqueira <rai93siqueira@gmail.com>

Author: raisiqueira

README.md

@@ -477,14 +477,23 @@ Run Django's system checks to identify potential issues in models, settings, and
 Read recent lines from file-based log handlers configured in `LOGGING.handlers`.
 
 **Arguments:**
-- `lines`: Number of lines to return per file (default: `100`, max: `1000`)
+- `lines`: Number of lines to return per file (default: `100`, configurable via `DJANGO_MCP_MAX_LOG_LINES` env var)
 - `handler_name`: Optional handler name to read from a single file handler
 
-**Safety and behavior:**
-- Reads only handlers backed by `*FileHandler` classes
-- Returns structured errors for invalid inputs and missing handlers
-- Uses UTF-8 with safe replacement for undecodable bytes
-- Returns file existence status without modifying files
+> **Note:** This tool reads only file-based handlers (`*FileHandler` classes). If your project logs to the console only, configure a `FileHandler` in your Django `LOGGING` settings so the AI can access log output. Example:
+>
+> ```python
+> LOGGING = {
+>     "version": 1,
+>     "handlers": {
+>         "file": {
+>             "class": "logging.FileHandler",
+>             "filename": "django.log",
+>         },
+>     },
+>     "root": {"handlers": ["file"], "level": "INFO"},
+> }
+> ```
 
 
 ### Prompts
@@ -550,12 +559,6 @@ uv run pytest test_server.py
 # Run focused MCP tool tests
 uv run pytest test_auth_logic.py test_prompt.py test_query_model.py test_read_recent_logs.py test_run_check.py
 
-# Run a single test file
-uv run pytest test_query_model.py
-
-# Run a single test function
-uv run pytest test_auth_logic.py::test_validation_logic
-
 # Run the MCP server with the test project
 export PYTHONPATH="${PYTHONPATH}:./fixtures/testproject"
 uv run django-ai-boost --settings testproject.settings

src/django_ai_boost/server_fastmcp.py

@@ -754,7 +754,7 @@ async def read_recent_logs(
     Read recent lines from file-based Django log handlers safely.
 
     Args:
-        lines: Number of recent lines to read per handler (default: 100, max: 1000)
+        lines: Number of recent lines to read per handler (default: 100, cap set via DJANGO_MCP_MAX_LOG_LINES env var, default cap: 5000)
         handler_name: Optional handler name to target one configured handler
 
     Returns:
@@ -763,7 +763,7 @@ async def read_recent_logs(
 
     @sync_to_async
     def read_logs():
-        max_lines = 1000
+        max_lines = int(os.environ.get("DJANGO_MCP_MAX_LOG_LINES", 5000))
 
         if lines < 1:
             return {"error": "lines must be greater than 0"}
@@ -773,20 +773,21 @@ def read_logs():
         handlers_config = logging_config.get("handlers", {})
 
         file_handlers: dict[str, Path] = {}
+        path_errors: dict[str, str] = {}
 
         for name, config in handlers_config.items():
-            if not isinstance(config, dict):
-                continue
-
             handler_class = str(config.get("class", ""))
             filename = config.get("filename")
 
             if not filename or not handler_class.endswith("FileHandler"):
                 continue
 
-            file_handlers[name] = Path(str(filename)).expanduser().resolve()
+            try:
+                file_handlers[name] = Path(str(filename)).expanduser().resolve()
+            except Exception as e:
+                path_errors[name] = str(e)
 
-        if not file_handlers:
+        if not file_handlers and not path_errors:
             return {"error": "No file-based log handlers found in LOGGING settings"}
 
         if handler_name:
@@ -800,6 +801,9 @@ def read_logs():
 
         logs: list[dict[str, Any]] = []
 
+        for name, error_msg in sorted(path_errors.items()):
+            logs.append({"handler": name, "error": f"Error resolving log file path: {error_msg}"})
+
         for name, file_path in sorted(target_handlers.items()):
             log_result: dict[str, Any] = {
                 "handler": name,
@@ -944,9 +948,9 @@ def run_server(
 
     # Run the server
     if transport == "sse":
-        mcp_server.run(transport="sse", host=host, port=port)
+        mcp_server.run(transport=transport, host=host, port=port)
     else:
-        mcp_server.run(transport="stdio")
+        mcp_server.run(transport=transport)
 
 
 if __name__ == "__main__":

test_read_recent_logs.py

@@ -29,7 +29,8 @@ async def test_read_recent_logs_success(
     assert any(marker in line for line in result["logs"][0]["lines"])
 
 
-async def test_read_recent_logs_limit_cap() -> None:
+async def test_read_recent_logs_limit_cap(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.setenv("DJANGO_MCP_MAX_LOG_LINES", "1000")
     result = await read_recent_logs(lines=9999, handler_name="file")
 
     assert "error" not in result