feat: add String.replaceRegex method#42
Open
wingyplus wants to merge 1 commit into
Open
Conversation
Adds replaceRegex(pattern, new, count) to the String stdlib, similar to String.replace but accepts a RE2 regular expression as the search pattern. Supports capture group substitution ($1, $2, ...) and the same count parameter as replace (-1 replaces all, n >= 0 limits replacements). Also adds tests/test_string_replace_regex.dang covering replace-all, count-limited, capture groups, and case-insensitive patterns. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
wingyplus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds replaceRegex(pattern, new, count) to the String stdlib, similar to String.replace but accepts a RE2 regular expression as the search pattern. Supports capture group substitution ($1, $2, ...) and the same count parameter as replace (-1 replaces all, n >= 0 limits replacements). Also adds tests/test_string_replace_regex.dang covering replace-all, count-limited, capture groups, and case-insensitive patterns.
I found this method is useful when we want to replace a complex string with a new one, for example, replace an image in sdk/elixir/runtime/main.go to match with the image defined in the elixir-sdk toolchain.