From 8c2fd2aa5384c39ff51e81f74e16fc2b09ab2a14 Mon Sep 17 00:00:00 2001 From: Walter Perdan Date: Sat, 20 Jun 2026 18:36:01 +0200 Subject: [PATCH 1/2] chore(#50): bump submodule (Tier-3 pose-math removal) + rebuild Companion to webarkit/WebARKitLib#58. Bump the submodule to the commit removing the superseded computePose/invertPose/computeGLviewMatrix()-noarg, and rebuild build/ + dist/ (emscripten output is not byte-reproducible). docs/audit-dead-code-issue50.md: move the computePose cluster from "pending" to "removed (#58)"; the #50 audit is now complete (everything else decided KEEP). Verified: static example tracks (pyrLevel 1, 1000 matches); live pose path unchanged. Co-Authored-By: Claude Opus 4.8 --- docs/audit-dead-code-issue50.md | 8 +++++--- emscripten/WebARKitLib | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/audit-dead-code-issue50.md b/docs/audit-dead-code-issue50.md index 50009ed..04c347a 100644 --- a/docs/audit-dead-code-issue50.md +++ b/docs/audit-dead-code-issue50.md @@ -77,10 +77,12 @@ and `arglCameraViewRHf(cv::Mat)` overloads, `webarkitGetVersion(char**)` + the `WEBARKIT_HEADER_VERSION_MAJOR/MINOR/TINY/DEV` constants, `N`, `featureDetectPyramidLevel`, and `grayscale()` — kept as plausible public API / OCVConfig parity. -### Pending decision +### Removed — webarkit/WebARKitLib#58 (Tier 3) - `computePose` / `invertPose` / `computeGLviewMatrix()` (no-arg) — WebARKit's own - pose math, superseded by `cameraPoseFromPoints` + the #55 `pose3d` fix. Not yet - removed; awaiting a keep/remove call. + pose math, superseded by `cameraPoseFromPoints` + the #55 `pose3d` fix. Removed + (behavior-neutral; the live `cameraPoseFromPoints` → `getTrackablePose` → + `updateTrackable` → `computeGLviewMatrix(cv::Mat&)` path is unchanged). With this, + the #50 audit is complete — every remaining flagged symbol was decided KEEP. --- diff --git a/emscripten/WebARKitLib b/emscripten/WebARKitLib index f6bca84..d23f9de 160000 --- a/emscripten/WebARKitLib +++ b/emscripten/WebARKitLib @@ -1 +1 @@ -Subproject commit f6bca84c5b175cdf205280344a824f0838305c91 +Subproject commit d23f9de7d6b370ede6038e06f464278fdb8eae99 From 9538f9fe736df9e7322007b100e3af0285e88e97 Mon Sep 17 00:00:00 2001 From: Walter Perdan Date: Sat, 20 Jun 2026 18:50:56 +0200 Subject: [PATCH 2/2] chore: bump WebARKitLib to merged dev (e6f87fa) Re-point the submodule at the canonical webarkit/WebARKitLib dev tip after #58 (Tier-3: remove superseded computePose/invertPose/computeGLviewMatrix()) merged. Completes the #50 dead-code cleanup. Co-Authored-By: Claude Opus 4.8 --- emscripten/WebARKitLib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emscripten/WebARKitLib b/emscripten/WebARKitLib index d23f9de..e6f87fa 160000 --- a/emscripten/WebARKitLib +++ b/emscripten/WebARKitLib @@ -1 +1 @@ -Subproject commit d23f9de7d6b370ede6038e06f464278fdb8eae99 +Subproject commit e6f87fa3e87386cfa1848a914eb99861e1159804