Retreat userinfo as basic auth if present in URL

Author: jswanner

lib/req.ex

@@ -599,7 +599,14 @@ defmodule Req do
     request =
       Enum.reduce(request_options, request, fn
         {:url, url}, acc ->
-          put_in(acc.url, URI.parse(url))
+          case URI.parse(url) do
+            uri when is_binary(uri.userinfo) ->
+              acc = put_in(acc.url, %{uri | userinfo: nil})
+              update_in(acc.options, &Map.put_new(&1, :auth, {:basic, uri.userinfo}))
+
+            uri ->
+              put_in(acc.url, uri)
+          end
 
         {:headers, new_headers}, acc ->
           update_in(acc.headers, &Req.Fields.merge(&1, new_headers))

test/req_test.exs

@@ -65,6 +65,31 @@ defmodule ReqTest do
     assert headers == [{"x-a", "2"}, {"x-b", "1"}]
   end
 
+  test "respects userinfo in URL", c do
+    pid = self()
+
+    Bypass.expect(c.bypass, "GET", "/", fn conn ->
+      case List.keyfind(conn.req_headers, "authorization", 0) do
+        {_, auth_header} -> send(pid, {:authorization, auth_header})
+        _ -> nil
+      end
+
+      Plug.Conn.send_resp(conn, 200, "ok")
+    end)
+
+    with_userinfo = String.replace(c.url, "http://", "http://foo:bar@")
+    Req.get!(with_userinfo)
+    assert_receive {:authorization, "Basic " <> _}
+
+    # explicit :auth option is favored over userinfo in URL
+    Req.get!(with_userinfo, auth: {:bearer, "token"})
+    assert_receive {:authorization, "Bearer token"}
+
+    req = Req.new(auth: {:bearer, "token"})
+    Req.get!(req, url: with_userinfo)
+    assert_receive {:authorization, "Bearer token"}
+  end
+
   test "redact" do
     assert inspect(Req.new(auth: {:bearer, "foo"})) =~ ~s|auth: {:bearer, "***"}|