chore: Disable public document subscription when SMTP is not configured (outline#11938)

Author: tommoor

app/components/Sharing/Collection/PublicAccess.tsx

@@ -207,31 +207,33 @@ function InnerPublicAccess(
                 />
               }
             />
-            <ListItem
-              title={
-                <Text type="tertiary" as={Flex}>
-                  {t("Email subscriptions")}&nbsp;
-                  <Tooltip
-                    content={t(
-                      "Allow viewers to subscribe and receive email notifications when documents are updated"
-                    )}
-                  >
-                    <NudeButton size={18}>
-                      <QuestionMarkIcon size={18} />
-                    </NudeButton>
-                  </Tooltip>
-                </Text>
-              }
-              actions={
-                <Switch
-                  aria-label={t("Email subscriptions")}
-                  checked={share?.allowSubscriptions ?? true}
-                  onChange={handleSubscriptionsChanged}
-                  width={26}
-                  height={14}
-                />
-              }
-            />
+            {env.EMAIL_ENABLED && (
+              <ListItem
+                title={
+                  <Text type="tertiary" as={Flex}>
+                    {t("Email subscriptions")}&nbsp;
+                    <Tooltip
+                      content={t(
+                        "Allow viewers to subscribe and receive email notifications when documents are updated"
+                      )}
+                    >
+                      <NudeButton size={18}>
+                        <QuestionMarkIcon size={18} />
+                      </NudeButton>
+                    </Tooltip>
+                  </Text>
+                }
+                actions={
+                  <Switch
+                    aria-label={t("Email subscriptions")}
+                    checked={share?.allowSubscriptions ?? true}
+                    onChange={handleSubscriptionsChanged}
+                    width={26}
+                    height={14}
+                  />
+                }
+              />
+            )}
             <ListItem
               title={
                 <Text type="tertiary" as={Flex}>

app/components/Sharing/Document/PublicAccess.tsx

@@ -251,31 +251,33 @@ function PublicAccess(
                 />
               }
             />
-            <ListItem
-              title={
-                <Text type="tertiary" as={Flex}>
-                  {t("Email subscriptions")}&nbsp;
-                  <Tooltip
-                    content={t(
-                      "Allow viewers to subscribe and receive email notifications when this document is updated"
-                    )}
-                  >
-                    <NudeButton size={18}>
-                      <QuestionMarkIcon size={18} />
-                    </NudeButton>
-                  </Tooltip>
-                </Text>
-              }
-              actions={
-                <Switch
-                  aria-label={t("Email subscriptions")}
-                  checked={share?.allowSubscriptions ?? true}
-                  onChange={handleSubscriptionsChanged}
-                  width={26}
-                  height={14}
-                />
-              }
-            />
+            {env.EMAIL_ENABLED && (
+              <ListItem
+                title={
+                  <Text type="tertiary" as={Flex}>
+                    {t("Email subscriptions")}&nbsp;
+                    <Tooltip
+                      content={t(
+                        "Allow viewers to subscribe and receive email notifications when this document is updated"
+                      )}
+                    >
+                      <NudeButton size={18}>
+                        <QuestionMarkIcon size={18} />
+                      </NudeButton>
+                    </Tooltip>
+                  </Text>
+                }
+                actions={
+                  <Switch
+                    aria-label={t("Email subscriptions")}
+                    checked={share?.allowSubscriptions ?? true}
+                    onChange={handleSubscriptionsChanged}
+                    width={26}
+                    height={14}
+                  />
+                }
+              />
+            )}
             <ListItem
               title={
                 <Text type="tertiary" as={Flex}>

app/scenes/Document/components/Header.tsx

@@ -34,6 +34,7 @@ import DocumentMenu from "~/menus/DocumentMenu";
 import NewChildDocumentMenu from "~/menus/NewChildDocumentMenu";
 import TableOfContentsMenu from "~/menus/TableOfContentsMenu";
 import TemplatesMenu from "~/menus/TemplatesMenu";
+import env from "~/env";
 import { documentEditPath } from "~/utils/routeHelpers";
 import ObservingBanner from "./ObservingBanner";
 import PublicBreadcrumb from "./PublicBreadcrumb";
@@ -213,7 +214,7 @@ function DocumentHeader({
         }
         actions={
           <>
-            {allowSubscriptions !== false && !user && (
+            {allowSubscriptions !== false && !user && env.EMAIL_ENABLED && (
               <SubscribeAction shareId={shareId} documentId={document.id} />
             )}
             <AppearanceAction />

server/routes/api/shares/shares.ts

@@ -441,6 +441,10 @@ router.post(
   validate(T.SharesSubscribeSchema),
   transaction(),
   async (ctx: APIContext<T.SharesSubscribeReq>) => {
+    if (!env.EMAIL_ENABLED) {
+      throw InvalidRequestError("Email is not configured");
+    }
+
     const { shareId, documentId, email } = ctx.input.body;
     const { transaction } = ctx.state;
     const team = await getTeamFromContext(ctx, { includeStateCookie: false });