fix: 204 response for internal docs not found (outline#12067)

Author: tommoor

server/routes/api/urls/urls.test.ts

@@ -143,6 +143,16 @@ describe("#urls.unfurl", () => {
     expect(body.name).toEqual(mentionedUser.name);
   });
 
+  it("should return 204 when internal document url points to non-existent document", async () => {
+    const res = await server.post("/api/urls.unfurl", {
+      body: {
+        token: user.getJwtToken(),
+        url: `${env.URL}/doc/non-existent-doc-abc123`,
+      },
+    });
+    expect(res.status).toEqual(204);
+  });
+
   it("should succeed with status 200 ok when valid document url is supplied", async () => {
     const document = await buildDocument({
       teamId: user.teamId,

server/routes/api/urls/urls.ts

@@ -164,10 +164,10 @@ router.post(
         const document = await Document.findByPk(previewDocumentId, {
           userId: actor.id,
         });
-        if (!document) {
-          throw NotFoundError("Document does not exist");
+        if (!document || !can(actor, "read", document)) {
+          ctx.response.status = 204;
+          return;
         }
-        authorize(actor, "read", document);
 
         ctx.body = await presentUnfurl({
           type: UnfurlResourceType.Document,