Default PDF attachments to non-embedded on upload (outline#11745)

* Initial plan

* Default PDF preview to false when uploading via drag and drop

Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>

* Preserve PDF preview for block menu option and attachment replacement

Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>

Author: Copilot

app/editor/menus/block.tsx

@@ -126,6 +126,7 @@ export default function blockMenuItems(
         accept: "application/pdf",
         width: 300,
         height: 424,
+        preview: true,
       },
     },
     {

shared/editor/commands/insertFiles.ts

@@ -39,6 +39,8 @@ export type Options = {
     alt?: string | null;
     /** Layout class for alignment when inserting image */
     layoutClass?: string | null;
+    /** Whether to show a PDF preview embed for attachment nodes */
+    preview?: boolean;
   };
 };
 
@@ -82,7 +84,6 @@ const insertFiles = async function (
         FileHelper.isVideo(file.type) &&
         !options.isAttachment &&
         !!schema.nodes.video;
-      const isPdf = FileHelper.isPdf(file.type) && !options.isAttachment;
       const getDimensions = isImage
         ? FileHelper.getImageDimensions
         : isVideo
@@ -95,7 +96,6 @@ const insertFiles = async function (
         source: await FileHelper.getImageSourceAttr(file),
         isImage,
         isVideo,
-        isPdf,
         file,
       };
     })
@@ -204,7 +204,7 @@ const insertFiles = async function (
                   title: upload.file.name ?? dictionary.untitled,
                   size: upload.file.size,
                   contentType: upload.file.type,
-                  preview: upload.isPdf,
+                  preview: false,
                   ...options.attrs,
                 })
               )

shared/editor/nodes/Attachment.tsx

@@ -209,6 +209,9 @@ export default class Attachment extends Node {
             onFileUploadProgress,
             dictionary: this.options.dictionary,
             replaceExisting: true,
+            attrs: {
+              preview: node.attrs.preview,
+            },
           });
         };
         inputElement.click();