Streaming HTTP body types #104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this PR just to show some ideas. The code here is pretty ugly and should not be merged as is.
The main goal was to do some experiments with
HttpResponse::bodytype - make it generic and see what happens.Basically changes are:
HttpResponseis nowHttpResponse<T = Vec<u8>>CacheManageris nowCacheManager<R = Vec<u8>>I another impl to
CACacheManager:CacheManager<cacache::Reader>which doesn't read the whole body of HTTP response into memory at once. However now when I'm looking at it I think I messed up here cause I don't see a clear way to usecacache::Readerfor user as an input. Probably some additional interface insidehttp-cacheitself is needed here.I don't see any way to achieve this without breaking changes though - and this is probably concerning,
Again this is just WIP on some ideas, not a ready-to-go code suggestion.