Fix LLMObs span double-exit issue with exit state tracking#2
Merged
0Shark merged 3 commits intofeature/datadog-setupfrom Nov 29, 2025
Merged
Fix LLMObs span double-exit issue with exit state tracking#20Shark merged 3 commits intofeature/datadog-setupfrom
0Shark merged 3 commits intofeature/datadog-setupfrom
Conversation
Merged
Co-authored-by: 0Shark <47896217+0Shark@users.noreply.github.com>
Co-authored-by: 0Shark <47896217+0Shark@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Datadog setup pull request
Fix LLMObs span double-exit issue with exit state tracking
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LLMObs span cleanup logic could call
__exit__twice on the same span—once in the error handler and once in the success path—causing potential errors.Changes
llmobs_span_exitedflag to track span exit state✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.