Draft
Conversation
balakumarr15
left a comment
balakumarr15
left a comment
There was a problem hiding this comment.
Added few basic comments that could improve code clarity. Please check these. Thanks.
| PrintError(err.Error()) | ||
| return "", err | ||
| } | ||
| defer sys.Files.Remove(option.LocalPath) //nolint |
There was a problem hiding this comment.
Is deferring here would be fine? If the number of iterations goes long, all accumulated files will be deferred to get deleted at end of function call.
There was a problem hiding this comment.
Create an anonymous function within this iteration if it needs to be deleted within this iteration.
|
|
||
| // getMintWZCNPayload returns the mint payload for the given burn transaction hash | ||
| // - burnTrxHash: hash of the burn transaction | ||
| func getMintWZCNPayloadMW(burnTrxHash string, key string) string { //nolint:unused |
There was a problem hiding this comment.
Key is passed here but not used. Please check its usage, similar to mintZCNMW function
| // - amountToken: amount of tokens to mint (as a string) | ||
| // - nonce: nonce of the transaction | ||
| // - signaturesRaw: encoded format (base-64) of the burn signatures received from the authorizers. | ||
| func estimateMintWZCNGasAmountMW(from, to, zcnTransaction, amountToken string, nonce int64, signaturesRaw []string, key string) string { // nolint:golint,unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-Wallet Support & Stability Fixes
This PR introduces comprehensive Multi-Wallet support for the Go SDK and includes critical stability fixes verified by a new system test suite.
1. New Features (Multi-Wallet Support)
_mw.gofiles to expose multi-wallet functionality to web clients (WASM SDK).OwnerPublicKeyfield in Allocation to distinguish between the allocation owner and the specific signing wallet.multiWalletSupportKeylogic, allowing operations to be signed by secondary wallets.2. Stability & Bug Fixes (New)
3. Verification (New System Test Suite)
Added a complete
sdk_testssuite tosystem_testto validate these changes. All 24 tests passed with 0 skips: