Skip to content

remove log imports #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dabasov merged 1 commit into from
Mar 23, 2025
Merged

remove log imports #669

dabasov merged 1 commit into from
Mar 23, 2025

Conversation

@storybehind
Copy link
Collaborator

@storybehind storybehind commented Mar 21, 2025

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@storybehind storybehind marked this pull request as ready for review March 22, 2025 11:13
@storybehind storybehind requested a review from dabasov March 22, 2025 11:13
dabasov
dabasov approved these changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 0763e31 into staging Mar 23, 2025
5 of 7 checks passed
@dabasov dabasov deleted the error-log-stderr branch March 23, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dabasov dabasov dabasov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@storybehind @dabasov