Skip to content

Conversation

@0verEngineer
Copy link
Owner

[0.5.6]

Changed

  • Added 2 settings options to disable HTML stripping and XML unescaping

Fixed

  • Generics in error messages were stripped because of the HTML stripping

- Added 2 settings options to disable HTML stripping and XML unescaping
Fixed:
- Generics in error messages were stripped because of the HTML stripping
Improve HTML Stripping and XML unescaping
@github-actions
Copy link

Qodana Community for JVM

10 new problems were found

Inspection name Severity Problems
Nullability and data flow problems 🔶 Warning 2
Unstable API Usage 🔶 Warning 2
Condition is covered by further condition 🔶 Warning 1
Constant values 🔶 Warning 1
Deprecated API usage 🔶 Warning 1
String concatenation in loop 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Unnecessary 'return' statement 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

Qodana Community for JVM

10 new problems were found

Inspection name Severity Problems
Nullability and data flow problems 🔶 Warning 2
Unstable API Usage 🔶 Warning 2
Condition is covered by further condition 🔶 Warning 1
Constant values 🔶 Warning 1
Deprecated API usage 🔶 Warning 1
String concatenation in loop 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Unnecessary 'return' statement 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

if (
settingsState.isEnableHtmlStripping() &&
text.contains("<") &&
RegexPattern.HTML_TAG_PATTERN.matcher(text).find()
Copy link

@yluom yluom Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how this fixes #69, but won't you have the same problem if the error contains html AND GenericTypes<LikeThis> ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely correct but i hope that HTML and generics in one error message does not happen very often... :D

And the HTML stripping can now be disabled in the settings so i think this is the best we can have without too much work.

@0verEngineer 0verEngineer merged commit eeea28e into release Apr 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants