Skip to content

added feature to hover and click in a error and get context window #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0verEngineer merged 2 commits into from
May 1, 2025
Merged

added feature to hover and click in a error and get context window #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5091d9f
added feature to hover and click in a error and get context window to…
khopland Apr 24, 2025
46a6aaf
small format changes and rename variable to clickableContext
khopland Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/overengineer/inlineproblems/InlineDrawer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public void drawProblemLabel(InlineProblem problem) {
problem,
drawDetails.getTextColor(),
drawDetails.getBackgroundColor(),
drawDetails.getTextColor().brighter(),
settings
);

Expand Down
99 changes: 86 additions & 13 deletions src/main/java/org/overengineer/inlineproblems/InlineProblemLabel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,50 @@
package org.overengineer.inlineproblems;

import com.intellij.codeInsight.hints.presentation.InputHandler;
import com.intellij.codeInsight.intention.impl.ShowIntentionActionsHandler;
import com.intellij.ide.ui.AntialiasingType;
import com.intellij.ide.ui.UISettings;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.IdeActions;
import com.intellij.openapi.actionSystem.ex.ActionUtil;
import com.intellij.openapi.editor.Editor;
import com.intellij.openapi.editor.EditorCustomElementRenderer;
import com.intellij.openapi.editor.Inlay;
import com.intellij.openapi.editor.ScrollType;
import com.intellij.openapi.editor.impl.FontInfo;
import com.intellij.openapi.editor.markup.GutterIconRenderer;
import com.intellij.openapi.editor.markup.TextAttributes;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiFile;
import com.intellij.psi.util.PsiUtilBase;
import com.intellij.ui.paint.EffectPainter;
import lombok.Getter;
import lombok.Setter;
import org.jdesktop.swingx.action.ActionManager;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.overengineer.inlineproblems.entities.InlineProblem;
import org.overengineer.inlineproblems.settings.SettingsState;
import org.overengineer.inlineproblems.utils.FontUtil;

import java.awt.*;
import java.awt.event.MouseEvent;
import java.awt.font.FontRenderContext;


@Getter
public class InlineProblemLabel implements EditorCustomElementRenderer {

public class InlineProblemLabel implements EditorCustomElementRenderer, InputHandler {
private final String text;
private final Color textColor;
private final Color backgroundColor;
private final Color hoverColor;
private final boolean isDrawBox;
private final boolean isRoundedCorners;
private final boolean isFillBackground;
private boolean hovered;
private final boolean clickableContext;
private Inlay<?> inlay;
private final int actualStartOffset;

@Setter
private boolean isBlockElement;
Expand All @@ -47,10 +63,12 @@ public InlineProblemLabel(
final InlineProblem problem,
final Color textColor,
final Color backgroundColor,
final Color hoverColor,
final SettingsState settings
) {
this.textColor = textColor;
this.backgroundColor = backgroundColor;
this.hoverColor = hoverColor;
this.isDrawBox = settings.isDrawBoxesAroundErrorLabels();
this.isRoundedCorners = settings.isRoundedCornerBoxes();
this.text = problem.getText();
Expand All @@ -59,6 +77,9 @@ public InlineProblemLabel(

this.isUseEditorFont = settings.isUseEditorFont();
this.inlayFontSizeDelta = settings.getInlayFontSizeDelta();
this.hovered = false;
this.actualStartOffset = problem.getActualStartffset();
this.clickableContext = settings.isClickableContext();
}

@Override
Expand All @@ -80,7 +101,7 @@ public int calcWidthInPixels(@NotNull Editor editor) {
@Override
public void paint(@NotNull Inlay inlay, @NotNull Graphics graphics, @NotNull Rectangle targetRegion, @NotNull TextAttributes textAttributes) {
Editor editor = inlay.getEditor();

this.inlay = inlay;
// These offsets are applied here and not in the calc functions itself because we use it to shrink the drawn stuff a little bit
int width = calcWidthInPixels(inlay) + DRAW_BOX_WIDTH_OFFSET;
int height = calcHeightInPixels(inlay) + DRAW_BOX_HEIGHT_OFFSET;
Expand All @@ -92,7 +113,7 @@ public void paint(@NotNull Inlay inlay, @NotNull Graphics graphics, @NotNull Rec
// Apply delta on the boxes
if (inlayFontSizeDelta != 0 && editorFontSize > inlayFontSizeDelta) {
height -= inlayFontSizeDelta;
targetRegionY += (int)(inlayFontSizeDelta / 1.5);
targetRegionY += (int) (inlayFontSizeDelta / 1.5);
}

if (isDrawBox) {
Expand All @@ -118,14 +139,13 @@ public void paint(@NotNull Inlay inlay, @NotNull Graphics graphics, @NotNull Rec
5
);
}
}
else {
graphics.drawRect(
targetRegion.x,
targetRegionY,
width,
height
);
} else {
graphics.drawRect(
targetRegion.x,
targetRegionY,
width,
height
);

if (isFillBackground) {
graphics.fillRect(
Expand All @@ -138,7 +158,7 @@ public void paint(@NotNull Inlay inlay, @NotNull Graphics graphics, @NotNull Rec
}
}

graphics.setColor(textColor);
graphics.setColor(hovered ? hoverColor : textColor);

graphics.setFont(FontUtil.getActiveFont(editor));

Expand All @@ -147,10 +167,63 @@ public void paint(@NotNull Inlay inlay, @NotNull Graphics graphics, @NotNull Rec
targetRegion.x + DRAW_STRING_LINE_PLACEMENT_OFFSET_X,
targetRegion.y + DRAW_STRING_LINE_PLACEMENT_OFFSET_Y + editor.getAscent()
);
if (hovered)
EffectPainter.LINE_UNDERSCORE.paint(
(Graphics2D) graphics,
targetRegion.x - DRAW_BOX_WIDTH_OFFSET,
targetRegion.y + editor.getAscent() ,
width + (DRAW_BOX_WIDTH_OFFSET * 2),
editor.getAscent(),
FontUtil.getActiveFont(editor));
}

private void setHovered(boolean hovered) {
if (!this.clickableContext || this.hovered == hovered) {
return;
}
this.hovered = hovered;
if (inlay != null)
inlay.repaint();
}

@Override
public @Nullable GutterIconRenderer calcGutterIconRenderer(@NotNull Inlay inlay) {
return EditorCustomElementRenderer.super.calcGutterIconRenderer(inlay);
}

@Override
public void mouseClicked(@NotNull MouseEvent mouseEvent, @NotNull Point point) {
if (!clickableContext) {
return;
}
if (mouseEvent.getButton() == MouseEvent.BUTTON1) {
mouseEvent.consume();

var editor = inlay.getEditor();
editor.getCaretModel().moveToOffset(actualStartOffset);
editor.getScrollingModel().scrollToCaret(ScrollType.CENTER);

var action = ActionManager.getInstance().getAction(IdeActions.ACTION_SHOW_INTENTION_ACTIONS);
if (action == null) {
Project project = editor.getProject();
if (project == null) return;
PsiFile psiFileInEditor = PsiUtilBase.getPsiFileInEditor(editor, project);
if (psiFileInEditor == null) return;
new ShowIntentionActionsHandler().invoke(project, editor, psiFileInEditor, false);
} else {
ActionUtil.invokeAction((AnAction) action, editor.getComponent(), "EditorInlay", null, null);
}
}
}

@Override
public void mouseMoved(@NotNull MouseEvent mouseEvent, @NotNull Point point) {
setHovered(true);
}

@Override
public void mouseExited() {
setHovered(false);
}

}
2 changes: 2 additions & 0 deletions src/main/java/org/overengineer/inlineproblems/entities/InlineProblem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public class InlineProblem {
private DrawDetails drawDetails;

private int actualEndOffset;
private int actualStartffset;

private boolean isBlockElement = false;

Expand Down Expand Up @@ -68,6 +69,7 @@ public InlineProblem(
this.project = textEditor.getEditor().getProject();
this.highlightInfoStartOffset = highlightInfo.hashCode();
this.rangeHighlighterHashCode = rangeHighlighter.hashCode();
this.actualStartffset = highlightInfo.getStartOffset();

if (highlightInfo.getActualEndOffset() == 0)
this.actualEndOffset = highlightInfo.getActualEndOffset();
Expand Down
19 changes: 15 additions & 4 deletions src/main/java/org/overengineer/inlineproblems/settings/SettingsComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ public class SettingsComponent {
private final JBCheckBox fillProblemLabels = new JBCheckBox(SettingsBundle.message("settings.fillProblemLabels"));
private final JBCheckBox boldProblemLabels = new JBCheckBox(SettingsBundle.message("settings.boldProblemLabels"));
private final JBCheckBox italicProblemLabels = new JBCheckBox(SettingsBundle.message("settings.italicProblemLabels"));
private final JBCheckBox clickableContext = new JBCheckBox(SettingsBundle.message("settings.enableClickableContext"));

private final JBTextField problemFilterList = new JBTextField();
private final JBTextField fileExtensionBlacklist = new JBTextField();

Expand All @@ -77,7 +79,7 @@ public class SettingsComponent {
private final JBTextField additionalInfoSeverities = new JBTextField();
private final JBTextField additionalWarningSeverities = new JBTextField();
private final JBTextField additionalWeakWarningSeverities = new JBTextField();
private final JBTextField additionalErrorSeverities = new JBTextField();
private final JBTextField additionalErrorSeverities = new JBTextField();

@Getter
private final JPanel settingsPanel;
Expand Down Expand Up @@ -133,6 +135,7 @@ public SettingsComponent() {
fillProblemLabels.setSelected(settingsState.isFillProblemLabels());
boldProblemLabels.setSelected(settingsState.isBoldProblemLabels());
italicProblemLabels.setSelected(settingsState.isItalicProblemLabels());
clickableContext.setSelected(settingsState.isClickableContext());

additionalInfoSeverities.setText(settingsState.getAdditionalInfoSeveritiesAsString());
additionalWeakWarningSeverities.setText(settingsState.getAdditionalWeakWarningSeveritiesAsString());
Expand All @@ -154,6 +157,7 @@ public SettingsComponent() {
.addComponent(fillProblemLabels, 0)
.addComponent(boldProblemLabels, 0)
.addComponent(italicProblemLabels, 0)
.addComponent(clickableContext, 0)
.addSeparator()
.addComponent(new JBLabel(SettingsBundle.message("settings.submenu.general")))
.addLabeledComponent(new JBLabel(SettingsBundle.message("settings.activeProblemListener")), enabledListener)
Expand Down Expand Up @@ -264,8 +268,8 @@ public int getInlayFontSizeDelta() {
// Convert the String
try {
val = Integer.parseInt(inlayFontSizeDeltaText.getText());
} catch (NumberFormatException ignored) {
}
catch (NumberFormatException ignored) {}

if (val < 0)
val = 0;
Expand Down Expand Up @@ -317,6 +321,14 @@ public void setItalicProblemLabels(boolean isSelected) {
italicProblemLabels.setSelected(isSelected);
}

public boolean isClickableContext() {
return clickableContext.isSelected();
}

public void setClickableContext(boolean isSelected) {
clickableContext.setSelected(isSelected);
}

public boolean isShowErrors() {
return showErrors.isSelected();
}
Expand Down Expand Up @@ -600,8 +612,7 @@ private List<Integer> getSeverityIntegerList(String text) {
public int getManualScannerDelay() {
try {
return Math.max(Integer.parseInt(manualScannerDelay.getText()), 10);
}
catch (NumberFormatException e) {
} catch (NumberFormatException e) {
return 100;
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/overengineer/inlineproblems/settings/SettingsConfigurable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public boolean isModified() {
state.isFillProblemLabels() == settingsComponent.isFillProblemLabels() &&
state.isBoldProblemLabels() == settingsComponent.isBoldProblemLabels() &&
state.isItalicProblemLabels() == settingsComponent.isItalicProblemLabels() &&
state.isClickableContext() == settingsComponent.isClickableContext() &&

state.getErrorTextColor().equals(settingsComponent.getErrorTextColor()) &&
state.getErrorBackgroundColor().equals(settingsComponent.getErrorLabelBackgroundColor()) &&
Expand Down Expand Up @@ -143,6 +144,7 @@ public void apply() {
state.setFillProblemLabels(settingsComponent.isFillProblemLabels());
state.setBoldProblemLabels(settingsComponent.isBoldProblemLabels());
state.setItalicProblemLabels(settingsComponent.isItalicProblemLabels());
state.setClickableContext(settingsComponent.isClickableContext());

state.setEnabledListener(settingsComponent.getEnabledListener());
state.setManualScannerDelay(settingsComponent.getManualScannerDelay());
Expand Down Expand Up @@ -213,6 +215,7 @@ public void reset() {
settingsComponent.setFillProblemLabels(state.isFillProblemLabels());
settingsComponent.setBoldProblemLabels(state.isBoldProblemLabels());
settingsComponent.setItalicProblemLabels(state.isItalicProblemLabels());
settingsComponent.setClickableContext(state.isClickableContext());

settingsComponent.setEnabledListener(state.getEnabledListener());
settingsComponent.setManualScannerDelay(state.getManualScannerDelay());
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/overengineer/inlineproblems/settings/SettingsState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public class SettingsState implements PersistentStateComponent<SettingsState> {
private boolean showInfos = false;
private boolean highlightInfos = false;
private boolean showInfosInGutter = false;
private boolean clickableContext = false;

/**
* Colors renamed from '<NAME>Color' to '<NAME>Col' to solve
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/messages/SettingsBundle_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ settings.forceProblemsInOneLine=Force problems in the same line even if they are
settings.useEditorFont=Use editor font instead of tooltip font
settings.showOnlyHighestPerLine=Show only the problem with the highest severity per line
settings.enableHtmlStripping=Enable stripping of HTML in the messages
settings.enableXmlUnescaping=Enable unescaping of XML in the messages
settings.enableXmlUnescaping=Enable unescaping of XML in the messages
settings.enableClickableContext=Enable clickable inline problems for IDE context actions
1 change: 1 addition & 0 deletions src/main/resources/messages/SettingsBundle_zh_CN.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ settings.useEditorFont=\u4F7F\u7528\u7F16\u8F91\u5668\u5B57\u4F53\u800C\u4E0D\u6
settings.showOnlyHighestPerLine=\u4ec5\u663e\u793a\u6bcf\u884c\u4e2d\u6700\u4e25\u91cd\u7684\u95ee\u9898
settings.enableHtmlStripping=Enable stripping of HTML in the messages
settings.enableXmlUnescaping=Enable unescaping of XML in the messages
settings.enableClickableContext=Enable clickable inline problems for IDE context actions
Loading