added feature to enable and disable all warings with a keybind #77
Conversation
src/main/java/org/overengineer/inlineproblems/actions/EnableInlineProblemsAction.java
Outdated
Show resolved
Hide resolved
|
|
||
| <actions> | ||
| <action class="org.overengineer.inlineproblems.actions.EnableInlineProblemsAction" | ||
| id="org.overengineer.inlineproblems.actions.EnableInlineProblemsAction" |
There was a problem hiding this comment.
Should i add a default key bind to this action?
There was a problem hiding this comment.
It would be cool, but we have to make sure it works on all platforms (or different binds for the platforms)
(Linux with KDE, Linux with Gnome, Windows and MacOS)
There was a problem hiding this comment.
@khopland Do you have a specific key binding in mind - or do you know which one does the VSCode equivalent use?
There was a problem hiding this comment.
looks like vs-code recomends ctrl + u
https://github.com/usernamehw/vscode-error-lens/blob/master/docs/docs.md
but i think its used already
There was a problem hiding this comment.
so i think we should have somthing like shift + ctrl + alt + u to make it not collide with another keybinding.
There was a problem hiding this comment.
I'll compare KDE, Gnome, Windows and MacOS keymaps later and check it
There was a problem hiding this comment.
It seems that alt+u is free in the default keymaps if i am not missing something.
There was a problem hiding this comment.
ok, can change to that
There was a problem hiding this comment.
And should we explain this somewhere in the description or the settings page? I think somewhere in the description would be nice.
|
BTW: I would also appreciate your input on this feature if you have any points or ideas to add: #78 |
|
Code looks good, thanks a lot for your contribution. I'll test it tomorrow so we can merge and release it :) |
src/main/java/org/overengineer/inlineproblems/actions/EnableInlineProblemsAction.java
Outdated
Show resolved
Hide resolved
khopland
force-pushed
the
feature/68-keybind
branch
from
f58228f to
f2b6036
Compare
khopland
force-pushed
the
feature/68-keybind
branch
from
f2b6036 to
a97ea83
Compare
2 participants
resolves #68