-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(tls): record negotiated TLS version #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for tracking negotiated TLS versions during the TLS handshake process. It extends the existing TLS inspection functionality by capturing and storing the final negotiated TLS version alongside the initial client hello information.
- Adds
tls_version_negotiatedfield to capture the final TLS version agreed upon during handshake - Updates connection tracking to store and pass negotiated TLS version information
- Integrates the negotiated version data into the TLS tracking info structure
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/server/tracker/inspector/tls/hello.rs | Adds negotiated TLS version field to ClientHello struct and setter method |
| src/server/tracker/info.rs | Updates ConnectionTrack to store negotiated TLS version and passes it to TLS tracking |
| src/server/tracker/accept.rs | Captures negotiated TLS version from the TLS stream during connection acceptance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.