Skip to content

Conversation

@0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Aug 12, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for tracking negotiated TLS versions during the TLS handshake process. It extends the existing TLS inspection functionality by capturing and storing the final negotiated TLS version alongside the initial client hello information.

  • Adds tls_version_negotiated field to capture the final TLS version agreed upon during handshake
  • Updates connection tracking to store and pass negotiated TLS version information
  • Integrates the negotiated version data into the TLS tracking info structure

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/server/tracker/inspector/tls/hello.rs Adds negotiated TLS version field to ClientHello struct and setter method
src/server/tracker/info.rs Updates ConnectionTrack to store negotiated TLS version and passes it to TLS tracking
src/server/tracker/accept.rs Captures negotiated TLS version from the TLS stream during connection acceptance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@0x676e67 0x676e67 changed the title feat(tls): add more TLS extension matching feat(tls): record negotiated TLS version Aug 12, 2025
@0x676e67 0x676e67 merged commit 6433936 into main Aug 12, 2025
4 checks passed
@0x676e67 0x676e67 deleted the feat branch August 12, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants