Skip to content

Conversation

@0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Nov 10, 2025

@0x676e67 0x676e67 requested a review from Copilot November 10, 2025 15:11
@0x676e67 0x676e67 marked this pull request as ready for review November 10, 2025 15:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the polling loop in the HTTP/1 client dispatcher to avoid premature yielding when there's still write work to be done. The key change ensures that when a body is being written and the connection becomes ready after flushing, the loop continues instead of yielding, which would cause a deadlock if no reads are expected.

Key changes:

  • Capture the flush readiness state to determine if more write work can be done
  • Introduce wants_write_again logic to check if body writing should continue
  • Update the loop exit condition to consider both read and write readiness

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@0x676e67
Copy link
Owner Author

0x676e67 commented Nov 10, 2025

keywords:

  • compression-core v0.4.29 -> v0.4.30
  • compression-codecs v0.4.30 -> v0.4.31

@0x676e67
Copy link
Owner Author

from: Nullus157/async-compression#420

@0x676e67 0x676e67 merged commit d6bccef into main Nov 11, 2025
6 checks passed
@0x676e67 0x676e67 deleted the fix branch November 11, 2025 15:34
0x676e67 added a commit that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants