Fix grammar in linux-initialization-1. #830

JDuchniewicz · 2023-04-15T11:39:26Z

More PRs will follow for next sections. Very helpful guide - adding some touches on style and grammar to make it easier to read.

Signed-off-by: Jakub Duchniewicz <[email protected]>

JDuchniewicz · 2023-09-02T10:27:59Z

Any plans to merge it @mudongliang? I saw you are maintaining this repo currently - I update stylistics and minor errors as I am reading through it. Hope it helps :)

mudongliang · 2023-09-04T02:31:58Z

Hi, your PR is a little long, I need some time to review them. Please be patient.

mudongliang · 2023-09-13T06:43:14Z

Initialization/linux-initialization-1.md

@@ -4,15 +4,15 @@ Kernel initialization. Part 1.
 First steps in the kernel code
 --------------------------------------------------------------------------------

-The previous [post](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) was a last part of the Linux kernel [booting process](https://0xax.gitbook.io/linux-insides/summary/booting) chapter and now we are starting to dive into initialization process of the Linux kernel. After the image of the Linux kernel is decompressed and placed in a correct place in memory, it starts to work. All previous parts describe the work of the Linux kernel setup code which does preparation before the first bytes of the Linux kernel code will be executed. From now we are in the kernel and all parts of this chapter will be devoted to the initialization process of the kernel before it will launch process with [pid](https://en.wikipedia.org/wiki/Process_identifier) `1`. There are many things to do before the kernel will start first `init` process. Hope we will see all of the preparations before kernel will start in this big chapter. We will start from the kernel entry point, which is located in the [arch/x86/kernel/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/kernel/head_64.S) and will move further and further. We will see first preparations like early page tables initialization, switch to a new descriptor in kernel space and many many more, before we will see the `start_kernel` function from the [init/main.c](https://github.com/torvalds/linux/blob/master/init/main.c) will be called.
+The previous [post](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) was a last part of the Linux kernel [booting process](https://0xax.gitbook.io/linux-insides/summary/booting) chapter and now we are starting to dive into the initialization process of the Linux kernel. After the image of the Linux kernel is decompressed and placed in a correct place in memory, it starts to work. All previous parts describe the work of the Linux kernel setup code which performs preparation before the first bytes of the Linux kernel code will be executed. From now on we are in the kernel and all parts of this chapter will be devoted to the initialization process of the kernel before it launches the process with the [pid](https://en.wikipedia.org/wiki/Process_identifier) `1`. There are many things to be done before the kernel starts first `init` process. Hopefully we will see all of the preparations before kernel starts throughout this big chapter. We will start from the kernel entry point, that is located in the [arch/x86/kernel/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/kernel/head_64.S) and will move further and further. We will see the initial preparations such as early page tables initialization, switching to a new descriptor in kernel space and many many more, before we see the `start_kernel` function from the [init/main.c](https://github.com/torvalds/linux/blob/master/init/main.c) being called.


starts first init process. -> starts the first init process

mudongliang · 2023-09-13T06:51:12Z

Initialization/linux-initialization-1.md

@@ -4,15 +4,15 @@ Kernel initialization. Part 1.
 First steps in the kernel code
 --------------------------------------------------------------------------------

-The previous [post](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) was a last part of the Linux kernel [booting process](https://0xax.gitbook.io/linux-insides/summary/booting) chapter and now we are starting to dive into initialization process of the Linux kernel. After the image of the Linux kernel is decompressed and placed in a correct place in memory, it starts to work. All previous parts describe the work of the Linux kernel setup code which does preparation before the first bytes of the Linux kernel code will be executed. From now we are in the kernel and all parts of this chapter will be devoted to the initialization process of the kernel before it will launch process with [pid](https://en.wikipedia.org/wiki/Process_identifier) `1`. There are many things to do before the kernel will start first `init` process. Hope we will see all of the preparations before kernel will start in this big chapter. We will start from the kernel entry point, which is located in the [arch/x86/kernel/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/kernel/head_64.S) and will move further and further. We will see first preparations like early page tables initialization, switch to a new descriptor in kernel space and many many more, before we will see the `start_kernel` function from the [init/main.c](https://github.com/torvalds/linux/blob/master/init/main.c) will be called.
+The previous [post](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) was a last part of the Linux kernel [booting process](https://0xax.gitbook.io/linux-insides/summary/booting) chapter and now we are starting to dive into the initialization process of the Linux kernel. After the image of the Linux kernel is decompressed and placed in a correct place in memory, it starts to work. All previous parts describe the work of the Linux kernel setup code which performs preparation before the first bytes of the Linux kernel code will be executed. From now on we are in the kernel and all parts of this chapter will be devoted to the initialization process of the kernel before it launches the process with the [pid](https://en.wikipedia.org/wiki/Process_identifier) `1`. There are many things to be done before the kernel starts first `init` process. Hopefully we will see all of the preparations before kernel starts throughout this big chapter. We will start from the kernel entry point, that is located in the [arch/x86/kernel/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/kernel/head_64.S) and will move further and further. We will see the initial preparations such as early page tables initialization, switching to a new descriptor in kernel space and many many more, before we see the `start_kernel` function from the [init/main.c](https://github.com/torvalds/linux/blob/master/init/main.c) being called.


before kernel starts -> before the kernel starts

Maybe you can try in the kernel initialization.

mudongliang · 2023-09-13T06:55:02Z

Initialization/linux-initialization-1.md

@@ -4,15 +4,15 @@ Kernel initialization. Part 1.
 First steps in the kernel code
 --------------------------------------------------------------------------------

-The previous [post](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) was a last part of the Linux kernel [booting process](https://0xax.gitbook.io/linux-insides/summary/booting) chapter and now we are starting to dive into initialization process of the Linux kernel. After the image of the Linux kernel is decompressed and placed in a correct place in memory, it starts to work. All previous parts describe the work of the Linux kernel setup code which does preparation before the first bytes of the Linux kernel code will be executed. From now we are in the kernel and all parts of this chapter will be devoted to the initialization process of the kernel before it will launch process with [pid](https://en.wikipedia.org/wiki/Process_identifier) `1`. There are many things to do before the kernel will start first `init` process. Hope we will see all of the preparations before kernel will start in this big chapter. We will start from the kernel entry point, which is located in the [arch/x86/kernel/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/kernel/head_64.S) and will move further and further. We will see first preparations like early page tables initialization, switch to a new descriptor in kernel space and many many more, before we will see the `start_kernel` function from the [init/main.c](https://github.com/torvalds/linux/blob/master/init/main.c) will be called.
+The previous [post](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) was a last part of the Linux kernel [booting process](https://0xax.gitbook.io/linux-insides/summary/booting) chapter and now we are starting to dive into the initialization process of the Linux kernel. After the image of the Linux kernel is decompressed and placed in a correct place in memory, it starts to work. All previous parts describe the work of the Linux kernel setup code which performs preparation before the first bytes of the Linux kernel code will be executed. From now on we are in the kernel and all parts of this chapter will be devoted to the initialization process of the kernel before it launches the process with the [pid](https://en.wikipedia.org/wiki/Process_identifier) `1`. There are many things to be done before the kernel starts first `init` process. Hopefully we will see all of the preparations before kernel starts throughout this big chapter. We will start from the kernel entry point, that is located in the [arch/x86/kernel/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/kernel/head_64.S) and will move further and further. We will see the initial preparations such as early page tables initialization, switching to a new descriptor in kernel space and many many more, before we see the `start_kernel` function from the [init/main.c](https://github.com/torvalds/linux/blob/master/init/main.c) being called.


We will see the initial preparations such as early page tables initialization, switching to a new descriptor in kernel space and many many more, before we see the start_kernel function from the init/main.c being called
->
We will see the initial preparations, such as, early page tables initialization, switching to a new descriptor in kernel space and many many more, before the function start_kernel from init/main.c is called.

mudongliang · 2023-09-13T07:00:29Z

Initialization/linux-initialization-1.md


 In the last [part](https://0xax.gitbook.io/linux-insides/summary/booting/linux-bootstrap-6) of the previous [chapter](https://0xax.gitbook.io/linux-insides/summary/booting) we stopped at the jmp instruction from the [arch/x86/boot/compressed/head_64.S](https://github.com/torvalds/linux/blob/master/arch/x86/boot/compressed/head_64.S) assembly source code file:

 ```assembly
 jmp	*%rax
 ```

-At this moment the `rax` register contains address of the Linux kernel entry point which was obtained as a result of the call of the `decompress_kernel` function from the [arch/x86/boot/compressed/misc.c](https://github.com/torvalds/linux/blob/master/arch/x86/boot/compressed/misc.c) source code file. So, our last instruction in the kernel setup code is a jump on the kernel entry point. We already know where the entry point of the Linux kernel is defined, so we are able to start to learn what Linux kernel does after the start.
+At this moment the `rax` register contains address of the Linux kernel entry point which was obtained as a result of the call of the `decompress_kernel` function from the [arch/x86/boot/compressed/misc.c](https://github.com/torvalds/linux/blob/master/arch/x86/boot/compressed/misc.c) source code file. So, our last instruction in the kernel setup code is a jump to the kernel entry point. We already know where the entry point of the Linux kernel is defined, so we are able to begin learning what Linux kernel does after the start.


"start" to "begin" is not necessary

"start" to "begin" is not necessary

@mudongliang
Are you suggesting the wording be kept as is?
Or are you indicating it be simplified?

We already know where the entry point of the Linux kernel is defined, so we are able to begin learning what Linux kernel does after the start.

We already know where the entry point of the Linux kernel is defined, so next we ~~are able to~~ begin learning what the Linux kernel does after the start.

mudongliang · 2023-09-13T07:02:27Z

Initialization/linux-initialization-1.md

@@ -47,10 +47,10 @@ We can see definition of this section in the [arch/x86/kernel/vmlinux.lds.S](htt
 } :text = 0x9090
 ```

-The ADDR keyword above returns the absolute address (here means virtual address) of the named section. The AT keyword above specifies the load address (here means physical address) of the section. The full syntax of section definition is defined in the [Using ld The GNU linker](https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_21.html). 
+The ADDR keyword above returns the absolute address (here meaning the virtual address) of the named section. The AT keyword above specifies the load address (here meaning the physical address) of the section. The full syntax of section definition is defined in the [Using ld The GNU linker](https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_21.html).


I think you can modify here means to i.e.,

mudongliang · 2023-09-13T07:08:43Z

A small suggestion: please split the changes of the whole section into several smaller PRs. It is easier for people to review.

JDuchniewicz · 2023-09-13T08:10:47Z

I think that splitting it in section by section PRs will be even harder to review as there will be a lot of them since every chapter contains 5-6 sections.

mudongliang · 2024-05-05T09:47:55Z

I think that splitting it in section by section PRs will be even harder to review as there will be a lot of them since every chapter contains 5-6 sections.

Yeah, you can balance the trade-off

mjbear · 2025-06-29T13:30:29Z

Initialization/linux-initialization-1.md

@@ -440,7 +440,7 @@ The `THREAD_SIZE` macro is defined in the [arch/x86/include/asm/page_64_types.h]
 #define THREAD_SIZE  (PAGE_SIZE << THREAD_SIZE_ORDER)
 ```

-We consider when the [kasan](https://github.com/torvalds/linux/blob/master/Documentation/dev-tools/kasan.rst) is disabled and the `PAGE_SIZE` is `4096` bytes. So the `THREAD_SIZE` will expands to `16` kilobytes and represents size of the stack of a thread. Why is `thread`? You may already know that each [process](https://en.wikipedia.org/wiki/Process_%28computing%29) may have [parent processes](https://en.wikipedia.org/wiki/Parent_process) and [child processes](https://en.wikipedia.org/wiki/Child_process). Actually, a parent process and child process differ in stack. A new kernel stack is allocated for a new process. In the Linux kernel this stack is represented by the [union](https://en.wikipedia.org/wiki/Union_type#C.2FC.2B.2B) with the `thread_info` structure.
+We consider the case when the [kasan](https://github.com/torvalds/linux/blob/master/Documentation/dev-tools/kasan.rst) is disabled and the `PAGE_SIZE` is `4096` bytes. So the `THREAD_SIZE` will expand to `16` kilobytes and represent size of the stack of a thread. Why is it a `thread`? You may already know that each [process](https://en.wikipedia.org/wiki/Process_%28computing%29) may have a [parent processes](https://en.wikipedia.org/wiki/Parent_process) and [child processes](https://en.wikipedia.org/wiki/Child_process). Actually, a parent process and child process differ in stack. A new kernel stack is allocated for a new process. In the Linux kernel this stack is represented by the [union](https://en.wikipedia.org/wiki/Union_type#C.2FC.2B.2B) with the `thread_info` structure.


Removing the plural from the link parent processes (grammatically and to match the hyperlink as well).

Suggested change

We consider the case when the [kasan](https://github.com/torvalds/linux/blob/master/Documentation/dev-tools/kasan.rst) is disabled and the `PAGE_SIZE` is `4096` bytes. So the `THREAD_SIZE` will expand to `16` kilobytes and represent size of the stack of a thread. Why is it a `thread`? You may already know that each [process](https://en.wikipedia.org/wiki/Process_%28computing%29) may have a [parent processes](https://en.wikipedia.org/wiki/Parent_process) and [child processes](https://en.wikipedia.org/wiki/Child_process). Actually, a parent process and child process differ in stack. A new kernel stack is allocated for a new process. In the Linux kernel this stack is represented by the [union](https://en.wikipedia.org/wiki/Union_type#C.2FC.2B.2B) with the `thread_info` structure.

We consider the case when the [kasan](https://github.com/torvalds/linux/blob/master/Documentation/dev-tools/kasan.rst) is disabled and the `PAGE_SIZE` is `4096` bytes. So the `THREAD_SIZE` will expand to `16` kilobytes and represent size of the stack of a thread. Why is it a `thread`? You may already know that each [process](https://en.wikipedia.org/wiki/Process_%28computing%29) may have a [parent process](https://en.wikipedia.org/wiki/Parent_process) and [child processes](https://en.wikipedia.org/wiki/Child_process). Actually, a parent process and child process differ in stack. A new kernel stack is allocated for a new process. In the Linux kernel this stack is represented by the [union](https://en.wikipedia.org/wiki/Union_type#C.2FC.2B.2B) with the `thread_info` structure.

mjbear · 2025-06-29T13:34:16Z

Initialization/linux-initialization-1.md

@@ -616,12 +616,12 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
 }
 ```

-It has one argument is a `real_mode_data` (remember that we passed address of the real mode data to the `rdi` register previously).
+It has a one argument is a `real_mode_data` (remember that we passed address of the real mode data to the `rdi` register previously).


Maybe rephrase the sentence?

Suggested change

It has a one argument is a `real_mode_data` (remember that we passed address of the real mode data to the `rdi` register previously).

It has one argument named `real_mode_data` (remember that we passed address of the real mode data to the `rdi` register previously).

Fix grammar in linux-initialization-1.

9c74a31

Signed-off-by: Jakub Duchniewicz <[email protected]>

mudongliang reviewed Sep 13, 2023

View reviewed changes

mjbear reviewed Jun 29, 2025

View reviewed changes

0xAX added the boot label Aug 11, 2025

0xAX added init and removed boot labels Aug 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix grammar in linux-initialization-1. #830

Fix grammar in linux-initialization-1. #830

Uh oh!

JDuchniewicz commented Apr 15, 2023 •

edited

Loading

Uh oh!

JDuchniewicz commented Sep 2, 2023

Uh oh!

mudongliang commented Sep 4, 2023

Uh oh!

mudongliang Sep 13, 2023

Uh oh!

mudongliang Sep 13, 2023 •

edited

Loading

Uh oh!

mudongliang Sep 13, 2023

Uh oh!

mudongliang Sep 13, 2023

Uh oh!

mjbear Jun 29, 2025

Uh oh!

mudongliang Sep 13, 2023

Uh oh!

mudongliang commented Sep 13, 2023

Uh oh!

JDuchniewicz commented Sep 13, 2023

Uh oh!

mudongliang commented May 5, 2024

Uh oh!

mjbear Jun 29, 2025

Uh oh!

mjbear Jun 29, 2025

Uh oh!

Uh oh!

	It has a one argument is a `real_mode_data` (remember that we passed address of the real mode data to the `rdi` register previously).
	It has one argument named `real_mode_data` (remember that we passed address of the real mode data to the `rdi` register previously).

Fix grammar in linux-initialization-1. #830

Are you sure you want to change the base?

Fix grammar in linux-initialization-1. #830

Uh oh!

Conversation

JDuchniewicz commented Apr 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JDuchniewicz commented Sep 2, 2023

Uh oh!

mudongliang commented Sep 4, 2023

Uh oh!

mudongliang Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

mudongliang Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mudongliang Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

mudongliang Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

mjbear Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

mudongliang Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

mudongliang commented Sep 13, 2023

Uh oh!

JDuchniewicz commented Sep 13, 2023

Uh oh!

mudongliang commented May 5, 2024

Uh oh!

mjbear Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

mjbear Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JDuchniewicz commented Apr 15, 2023 •

edited

Loading

mudongliang Sep 13, 2023 •

edited

Loading