Fix truncation of device addresses 0x40 and above + various enhancements#12
Open
tonyle72 wants to merge 6 commits into0xArt:mainfrom
Open
Fix truncation of device addresses 0x40 and above + various enhancements#12tonyle72 wants to merge 6 commits into0xArt:mainfrom
tonyle72 wants to merge 6 commits into0xArt:mainfrom
Conversation
…ns where appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update makes several fixes and improvements to the I2C master:
saved_device_addressMSB during barrel shifting. The testbench targets only one device address below 0x40, which is why this bug hasn't been caught until now.serial_data_output_enableduringS_READ_REG, to reduce wire contention during slave-output operation.busyto always mirror(state != S_IDLE). This allowsbusyto be used as a true not-ready indicator. Transaction parameters are now guaranteed to be captured when(reset_n && enable && !busy).saved_device_addressandsaved_read_write(rather than the live inputs) to prep for slave-data receive, preventing any input changes outside ofenablefrom sending a read operation astray.