Skip to content

Update to swift tools version 6.0#18

Closed
0xLeif wants to merge 4 commits intomainfrom
develop
Closed

Update to swift tools version 6.0#18
0xLeif wants to merge 4 commits intomainfrom
develop

Conversation

@0xLeif
Copy link
Owner

@0xLeif 0xLeif commented Apr 8, 2025

No description provided.

@0xLeif 0xLeif self-assigned this Apr 8, 2025
@0xLeif 0xLeif requested a review from Copilot May 18, 2025 05:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Swift package and CI workflows to target Swift 6.0 and the corresponding toolchains.

  • Bump swift-tools-version to 6.0 in Package.swift
  • Align Windows, Ubuntu, and macOS workflows with Swift 6.0 releases and broaden branch triggers
  • Introduce Linux Swift action and Xcode 16 setup, adjust runners

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
Package.swift Updated swift-tools-version to 6.0
.github/workflows/windows.yml Switched to Swift 6.0 release, broadened branch filter
.github/workflows/ubuntu.yml Added Swift Linux action, changed runner and branch filter
.github/workflows/macOS.yml Added Xcode 16 setup, broadened branch filter
Comments suppressed due to low confidence (1)

.github/workflows/ubuntu.yml:12

  • [nitpick] Pinning to ubuntu-20.04 may cause you to miss updates and security fixes; consider using ubuntu-latest for managed updates.
runs-on: ubuntu-20.04

branches: [ "main" ]
pull_request:
branches: [ "main" ]
branches: ["**"]
Copy link

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request trigger was removed from this workflow, so it will no longer run on pull requests. Please re-add a pull_request: section with the intended branch filter.

Suggested change
branches: ["**"]
branches: ["**"]
pull_request:
branches: ["**"]

Copilot uses AI. Check for mistakes.
branches: [ "main" ]
pull_request:
branches: [ "main" ]
branches: ["**"]
Copy link

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request trigger block was removed, so this workflow won't run on PRs. Consider adding a pull_request: section mirroring the push: filter.

Suggested change
branches: ["**"]
branches: ["**"]
pull_request:
branches: ["**"]

Copilot uses AI. Check for mistakes.
branches: [ "main" ]
pull_request:
branches: [ "main" ]
branches: ["**"]
Copy link

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request event was dropped in this change. Add back a pull_request: trigger if builds should run on PRs.

Suggested change
branches: ["**"]
branches: ["**"]
pull_request:
branches: ["**"]

Copilot uses AI. Check for mistakes.
@0xLeif 0xLeif closed this Jun 4, 2025
@0xLeif 0xLeif deleted the develop branch June 4, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants