feat(SmtForest): Make the entries iterator fallible#900
Merged
iamrecursion merged 1 commit intonextfrom Mar 16, 2026
Merged
Conversation
iamrecursion
force-pushed
the
forest-fallible-iterator
branch
from
bc730c5 to
ed96e0f
Compare
huitseeker
approved these changes
Mar 16, 2026
Contributor
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
Thanks a lot! This LGTM.
drahnr
approved these changes
Mar 16, 2026
This changes `LargeSmtForest::entries` to return an iterator over items that are `Result<TreeEntry>` instead of bare `TreeEntry`, ensuring that the potential failure of iteration in the backend is communicated clearly to the caller performing the iteration. We also add benchmarks to the iteration in order to confirm that the changes incur no performance impact.
iamrecursion
force-pushed
the
forest-fallible-iterator
branch
from
ed96e0f to
7c0e920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This changes
LargeSmtForest::entriesto return an iterator over items that areResult<TreeEntry>instead of bareTreeEntry, ensuring that the potential failure of iteration in the backend is communicated clearly to the caller performing the iteration.We also add benchmarks to the iteration in order to confirm that the changes incur no performance impact.
Closes #887.
Checklist before requesting a review
nextaccording to naming convention.