Skip to content

ci: Use repo permission to skip contribution quality#2956

Merged
huitseeker merged 2 commits intonextfrom
fix/contribution-quality-permissions
Apr 3, 2026
Merged

ci: Use repo permission to skip contribution quality#2956
huitseeker merged 2 commits intonextfrom
fix/contribution-quality-permissions

Conversation

@huitseeker
Copy link
Copy Markdown
Contributor

GitHub did not report trusted authors in a stable way on pull requests. Some Miden team members showed up as CONTRIBUTORS, so role checks could not tell team PRs from outside PRs. That pushed the workflow to skip too much.

This change uses the author's repo permission instead. The workflow now skips only authors with admin, maintain, or write access. Tested through API calls over the last 100 PRs to reflect the semantics we actually want.

GitHub did not report trusted authors in a stable way on pull requests. Some Miden team members showed up as CONTRIBUTORS, so role checks could not tell team PRs from outside PRs. That pushed the workflow to skip too much.\n\nThis change uses the author's repo permission instead. The workflow now skips only authors with admin, maintain, or write access.
@huitseeker huitseeker added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 1, 2026
@huitseeker huitseeker requested a review from mmagician April 2, 2026 09:40
@huitseeker huitseeker merged commit f5576e0 into next Apr 3, 2026
17 checks passed
@huitseeker huitseeker deleted the fix/contribution-quality-permissions branch April 3, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants