fix: return request key alongside smt proof#1790
Closed
juan518munoz wants to merge 2 commits intomainfrom
Closed
Conversation
Collaborator
|
But don't you already have the keys since you requested them? |
Contributor
|
As @Mirko-von-Leipzig said, you do have the keys, and you can apply the hash function to map the responded proofs back using a hashmap? I do understand it'd be more convenient to get the keys returned. @bobbinth was pretty concerned re request/response sizes (there is one more issue to compress these proofs even further), so I am not sure we want to throw in these bytes. |
Collaborator
Author
|
As discussed offline with @igamigo and @TomasArrachea, it makes sense to not return the keys as one can assume the user knows them beforehand (otherwise it'd be impossible to request proof of them). Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client calls
get_account_proofto request storage maps by passing specific keys, the node retrieves the requested values by querying the Smt forest with a hash of each requested key. Finally, the node returns the requested proofs with the hashed keys, when in reality the original requested keys are needed to construct theStorageMapWitness.Original discussion