feat: add miden-genesis tool for canonical genesis state#1797
Open
feat: add miden-genesis tool for canonical genesis state#1797
Conversation
New binary crate that generates canonical AggLayer genesis accounts (bridge, bridge admin, GER manager) and a genesis.toml config file. Only the bridge account is included in the genesis block; bridge admin and GER manager are generated as local accounts to be deployed later. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add description, keywords, and exclude to match other bin/ crate conventions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GenesisConfig and BlockHeader use u32 timestamps. Cast to u32 using the same pattern as proposed_block.rs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Decorator stripping was needed in build.rs for deterministic .mac files checked into the repo. The genesis tool generates files at runtime so stripping is unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that the tool generates all expected files with correct properties: bridge has nonce=1, admin/GER manager have nonce=0 with secret keys, and genesis.toml only references bridge.mac. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Validate that either both --bridge-admin-public-key and --ger-manager-public-key are provided, or neither. Add integration tests for both default mode (generated keypairs with secrets) and custom mode (provided public keys without secrets). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace manual match-based validation with clap's requires attribute, so clap handles the error message when only one public key is provided. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies the full round-trip: generate files, parse genesis.toml with GenesisConfig, build genesis state, confirm bridge account is present with nonce=1, and build the actual genesis block. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Both tests now verify the full round-trip through GenesisConfig and genesis block creation via a shared helper, removing redundant checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
While reviewing #1774, I came to realize that there is a split between what the I think eventually it might make sense to merge these two so that all account generation happens in a single step. The proposed split:
This way |
sergerad
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
miden-genesisbinary crate that generates canonical AggLayer genesis accounts and agenesis.tomlconfig fileBasicWallets), andAggLayerBridgegenesis.tomlfor the genesis block; bridge admin and GER manager are local accounts (nonce=0) to be deployed later via transactions. But, they are "implicitly" included in the genesis block in that theAggLayerBridgeaccount makes reference to them in its storage.Closes #1788
Operator workflow
🤖 Generated by hand & with Claude Code
I wanted to add this as a separate minimal binary (non-publishable) because I do see this as a separate role from the validator (even though for now they'll be run by the same entity). But it should be trivial to move this in a new command on the validator if desired.