Skip to content

refactor: reuse gRPC clients#1806

Open
juan518munoz wants to merge 1 commit intonextfrom
jmunoz-reuse-grpc-clients
Open

refactor: reuse gRPC clients#1806
juan518munoz wants to merge 1 commit intonextfrom
jmunoz-reuse-grpc-clients

Conversation

@juan518munoz
Copy link
Collaborator

Add ValidatorClient, a clonable thin wrapper around the gRPC client. This allows sharing of grpc channels accross actors.

Closes #1804

Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you add a changelog entry, e.g.

### Fixes

- Network transaction actors now share gRPC clients, reducing the number of file descriptors used

Could you confirm

Confirm that cloning a tonic gRPC client shares the underlying gRPC channel i.e. only consumes a single socket/file descriptor.

from #1804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reuse gRPC clients

2 participants