Skip to content

fix: Adjust the FPI tutorial to 0.12#144

Merged
Keinberger merged 7 commits intomainfrom
wiktor-adjust-fpi-tutorial
Nov 25, 2025
Merged

fix: Adjust the FPI tutorial to 0.12#144
Keinberger merged 7 commits intomainfrom
wiktor-adjust-fpi-tutorial

Conversation

@WiktorStarczewski
Copy link
Contributor

Adjusts the FPI tutorial to 0.12.
Mirrors 0xMiden/miden-docs#98.

@Keinberger
Copy link
Collaborator

Please update the corresponding .md file in the docs folder too!

Copy link
Collaborator

@Keinberger Keinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete the redundant console.log statements, i.e. among others "POST", "HERE", "PRE", etc...

I also don't think we need to console log the FPI script code.

@Keinberger
Copy link
Collaborator

Also, please make sure that other parts of the .md file are updated accordingly. For instance, the "Key WebClient Concepts for FPI" section needs to be updated with the new account component library syntax.

In regards to that point, please also review the .md files of the other web tutorials (even the ones that were already merged), in case there are any changes to the content of those md files that are still missing and need to be updated.

@Keinberger Keinberger force-pushed the wiktor-adjust-fpi-tutorial branch from 68052f8 to 838d70e Compare November 25, 2025 12:46
@Keinberger
Copy link
Collaborator

Made some more fixes to this PR, as can be seen by the commits above (removed redundant debugging messages, fixed the markdown tutorial instructions, etc...).

@WiktorStarczewski Please review the latest changes.

NOTE: Furthermore, we have an issue with our CI workflow that runs prettier: As of now, it uses the root prettier config. However, for the typescript markdown code, we want to use different linter settings than the rust code. That means we'll have to find a way to reconfigure the workflow to use different prettier settings for the Rust code and the Typescript code

@Keinberger Keinberger merged commit f8627c2 into main Nov 25, 2025
6 checks passed
@Keinberger Keinberger deleted the wiktor-adjust-fpi-tutorial branch November 25, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants