Handle error state for generating transactions correctly#69
Open
0xnullifier wants to merge 3 commits intomainfrom
Open
Handle error state for generating transactions correctly#690xnullifier wants to merge 3 commits intomainfrom
0xnullifier wants to merge 3 commits intomainfrom
Conversation
Collaborator
|
Is the intent to silently continue after a single transaction failure? Users won't see any error indication until all transactions finish. |
| } | ||
|
|
||
| mutateTx(); | ||
| await mutateTx(); |
Collaborator
There was a problem hiding this comment.
Is this intentional? It now blocks until the cache is updated before potentially retrying.
| transactions.length === 0 | ||
| ) { | ||
| new Promise(res => setTimeout(res, 10_000)).then(async () => { | ||
| new Promise(res => (timeOutRef.current = setTimeout(res, 10_000))).then(async () => { |
Collaborator
There was a problem hiding this comment.
Should this also check for error state?
Collaborator
Author
I tested this with the consuming note which handles the error state correctly for other than that I think dapps which send custom transaction will show if transaction fails but we can incorporate something into the UI too. Like a continue other transactions button |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.