fix: use modal for transaction progress in Chrome extension#87
Merged
WiktorStarczewski merged 5 commits intomainfrom Jan 23, 2026
Merged
fix: use modal for transaction progress in Chrome extension#87WiktorStarczewski merged 5 commits intomainfrom
WiktorStarczewski merged 5 commits intomainfrom
Conversation
0xnullifier
reviewed
Jan 22, 2026
Collaborator
Author
Error Handling is in TransactionProgressModal.tsx:
Error UI in GeneratingTransaction.tsx: When hasErrors=true and transactionComplete=true:
|
Collaborator
|
Yeah but if I closed the modal and then it throws error what happens then |
Collaborator
Author
Ah nice, yeah thats a good point. Let me fix this. |
Replace tab-opening pattern with in-popup modal for transaction progress, unifying UX across all platforms (mobile, desktop, extension). - Remove isExtension() early return in TransactionProgressModal - Simplify openLoadingFullPage/closeLoadingFullPage to use modal for all platforms - Update openConsumingFullPage/closeConsumingFullPage similarly - Pre-create modal container for all platforms in provider.tsx - Add smaller font/icon sizes for extension modal - Re-enable animate-spin for transaction progress spinner
When the user clicked "Hide" on the transaction modal, navigating back to the home page would reopen the modal because Explore.tsx auto-opens when queued transactions exist. Added isTransactionModalDismissedByUser flag to track user dismissal and skip auto-open until transactions complete or a new transaction is initiated.
Replace openLoadingFullPage/closeLoadingFullPage/openConsumingFullPage/ closeConsumingFullPage with direct useWalletStore.getState() calls. The wrapper functions were misleading (said "FullPage" but opened modals) and added unnecessary indirection. Also add mobile-e2e/ to Jest's testPathIgnorePatterns.
When user clicks Hide, transactions now continue processing in the background. If a transaction fails while the modal is hidden, it automatically re-opens to show the error to the user.
9ab3bdb to
ff3de11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace tab-opening pattern with in-popup modal for transaction progress, unifying UX across all platforms (mobile, desktop, extension).