Skip to content

Comments

Simplify e2e-tests CI by using the consolidated script#1423

Merged
kamuikatsurgi merged 2 commits intodevelopfrom
krishang/simplify-e2e-tests-ci
Jan 28, 2025
Merged

Simplify e2e-tests CI by using the consolidated script#1423
kamuikatsurgi merged 2 commits intodevelopfrom
krishang/simplify-e2e-tests-ci

Conversation

@kamuikatsurgi
Copy link
Member

Description

Uses the docker_devnet.sh script instead of single ones.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backward-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewers or the whole pos-v1 team
  • I have added sufficient documentation in the code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on the local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@kamuikatsurgi kamuikatsurgi requested a review from a team January 28, 2025 13:07
@kamuikatsurgi kamuikatsurgi merged commit ce4af04 into develop Jan 28, 2025
11 checks passed
@kamuikatsurgi kamuikatsurgi deleted the krishang/simplify-e2e-tests-ci branch January 28, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants